fix(deno_telemetry): guard against malformed request URLs in span attrs#691
Merged
johnstonmatt merged 1 commit intomainfrom Apr 19, 2026
Merged
Conversation
kallebysantos
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
Problem
updateSpanFromRequestinvendor/deno_telemetry/util.tscallsnew URL(request.url)unguarded. When the incomingrequest.urlismalformed (e.g. an invalid host like
nonexistent-jscorpus-probe.171340sent by internet scanners / security probes),
new URLthrowsTypeError: Invalid URLand crashes the request handler before it canrespond. The error surfaces as a handled exception in Sentry on every
scan, and any attacker can trivially generate noise.
Traced from incident INC-475.
Solution
Wrap the
new URL(...)call and the derived attribute writes in atry/catch:
url.full(the raw request URL string) andhttp.request.methodarenow set before the parse, so malformed-URL requests remain
observable in spans.
url.scheme/url.path/url.queryare only set when parsingsucceeds.
url.parse_error = "true"is set so these requestscan be filtered in telemetry.
This layer is a passive observer — it doesn't reject the request.
Request rejection (400 on malformed URL) is handled upstream in
edge-functions-ingress.