Skip to content

fix(deno_telemetry): guard against malformed request URLs in span attrs #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnstonmatt merged 1 commit into from
Apr 19, 2026
Merged

fix(deno_telemetry): guard against malformed request URLs in span attrs #691

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions vendor/deno_telemetry/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,21 @@ export function updateSpanFromRequest(span: Span, request: Request) {
span.updateName(request.method);

span.setAttribute("http.request.method", request.method);
const url = new URL(request.url);
span.setAttribute("url.full", request.url);
span.setAttribute(
"url.scheme",
StringPrototypeSlice(url.protocol, 0, -1),
);
span.setAttribute("url.path", url.pathname);
span.setAttribute("url.query", StringPrototypeSlice(url.search, 1));
// Malformed URLs (e.g. invalid hosts from internet scanners) would otherwise
// throw here and crash the request handler before it can respond. Record the
// raw URL above and skip the parsed attributes when parsing fails.
try {
const url = new URL(request.url);
span.setAttribute(
"url.scheme",
StringPrototypeSlice(url.protocol, 0, -1),
);
span.setAttribute("url.path", url.pathname);
span.setAttribute("url.query", StringPrototypeSlice(url.search, 1));
} catch {
span.setAttribute("url.parse_error", "true");
}
}

export function updateSpanFromResponse(span: Span, response: Response) {
Expand Down
Loading