perf: xtask sccache#788
Merged
Merged
Conversation
farazdagi
force-pushed
the
perf/xtask-build-isolation
branch
from
May 29, 2026 12:13
651071c to
d0083a6
Compare
farazdagi
force-pushed
the
perf/xtask-build-isolation
branch
from
May 29, 2026 12:22
dd477e8 to
e85299a
Compare
farazdagi
marked this pull request as ready for review
May 29, 2026 12:24
iambriccardo
approved these changes
May 29, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e85299a9f3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
bnjjj
approved these changes
May 29, 2026
farazdagi
enabled auto-merge (squash)
May 29, 2026 12:38
|
coverage: 72.577% (-0.05%) from 72.627% — perf/xtask-build-isolation into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
cargo xcommand gets its own target directory, so that normalcargo cmddoesn't invalidate compiled deps (andxtaskdoesn't have to rebuild when source code changes, unless it isxtask's code itself)ETL_SCCACHE=1or--sccachefor command to rely onsccache(provided it is intalled). Helps a lot with thoselibduckdb.sysrecompilations, local builds are faster now.Deliberately made the sccache an opt-in feature, use
source .env(created from.env.example) should you want to have a quick way to enable it for allcargo xcommands.