Skip to content

ref(api): Use requests == limits for better QoS class#888

Merged
iambriccardo merged 1 commit into
mainfrom
add-same-limits
Jul 8, 2026
Merged

ref(api): Use requests == limits for better QoS class#888
iambriccardo merged 1 commit into
mainfrom
add-same-limits

Conversation

@iambriccardo

@iambriccardo iambriccardo commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Default replicator CPU and memory limits to the final request values to help pods qualify for Kubernetes Guaranteed QoS.
  • Keep explicit pipeline-level replicator limits as the opt-out path for workloads that need extra headroom.
  • Set Vector sidecar limits equal to requests too, since every container in the pod must satisfy request == limit for Guaranteed QoS.
  • Update comments, config docs, unit expectations, and k8s snapshots.

@iambriccardo iambriccardo marked this pull request as ready for review July 8, 2026 12:25
@iambriccardo iambriccardo requested a review from a team as a code owner July 8, 2026 12:25
@iambriccardo iambriccardo enabled auto-merge (squash) July 8, 2026 12:33
@iambriccardo iambriccardo merged commit da679f2 into main Jul 8, 2026
21 checks passed
@iambriccardo iambriccardo deleted the add-same-limits branch July 8, 2026 12:47
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 72.901% (-0.07%) from 72.972% — add-same-limits into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants