Skip to content

tests: do not download all PG versions - #271

Merged
imor merged 2 commits into
test/fix-flaky-testsfrom
rs/do-not-download-all-pg-versions
Aug 1, 2026
Merged

tests: do not download all PG versions#271
imor merged 2 commits into
test/fix-flaky-testsfrom
rs/do-not-download-all-pg-versions

Conversation

@imor

@imor imor commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

xpg version 2.5.0 added support for downloading only one version of Postgres. This PR bumps xpg to 2.5.0 and uses it to download only the versions needed in a test workflow. This change downloads ~164 MBs less than previous versions.

@steve-chavez

Copy link
Copy Markdown
Member

@imor Why is this needed? I'm seeing the latest CI time to be around 2 mins f8a061c

@imor

imor commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

@imor Why is this needed? I'm seeing the latest CI time to be around 2 mins f8a061c

Thinking was that downloading less data from cache will improve build times but there's no material difference even though we are downloading a smaller size with this PR's change (shaving off ~164 MB):

Old:

these 515 paths will be fetched (735.26 MiB download, 3858.34 MiB unpacked):

New:

these 486 paths will be fetched (571.08 MiB download, 3337.61 MiB unpacked):

I guess network download is not on the critical path.

@steve-chavez

Copy link
Copy Markdown
Member

but there's no material difference even though we are downloading a smaller size with this PR's change (shaving off ~164 MB):
I guess network download is not on the critical path.

Right, I guess it can't hurt though so I'll proceed with the review.

Comment thread flake.lock Outdated
@imor
imor marked this pull request as ready for review August 1, 2026 04:19
@imor imor changed the title tests: do not download all PG versions to reduce CI time tests: do not download all PG versions Aug 1, 2026
@steve-chavez

Copy link
Copy Markdown
Member

Github stacks are new to me but this looks good to merge independently of the other PR

@imor

imor commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Github stacks are new to me but this looks good to merge independently of the other PR

I'm in the same boat, was experimenting with them and the basic idea is that you can keep interdependent PR branches updated automatically with GH stacks instead of manually rebasing when a dependency branch has new commits. I just wanted this PR to reuse the flaky test fixes, but as you said it's not really dependent on the other PR, so I'll detach it from the stack and merge.

@imor

imor commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

but there's no material difference even though we are downloading a smaller size with this PR's change (shaving off ~164 MB):
I guess network download is not on the critical path.

Right, I guess it can't hurt though so I'll proceed with the review.

By the way, the slowest test is test-on-macos which also now downloads less:

Old:

these 472 paths will be fetched (912.08 MiB download, 4747.92 MiB unpacked):

New:

these 438 paths will be fetched (773.32 MiB download, 4251.33 MiB unpacked):

@imor
imor merged commit ca6b6ec into test/fix-flaky-tests Aug 1, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants