pg_graphql: Avoid mass-rebuild on new latest version#2146
Open
pg_graphql: Avoid mass-rebuild on new latest version#2146
Conversation
Whenever we add a new version of pg_graphsql the postInstall hook for _every_ previous version is tainted due to a new `latestVersion` thus causing a mass-rebuild. This is unnecessary because we _should_ only need to re-build the previous default version (which would no longer be the default). But we can do better here actually, instead of guarding the `if` in nix vs bash, we can just do this in the buildEnv's postBuild so that we never have to rebuild previously built extension, they should be fetchable from cache.
Author
|
Was working on adding pg_graphql v1.6.1 and noticed that when I did so the old/previously built extensions were also being built. That didn't really make sense to me so I investigated. First attempt was going to keep the |
PostgreSQL Extension Dependency Analysis: PR #2146
SummaryNo extensions had dependencies with MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Extension DependenciesPostgreSQL 17 Extension DependenciesOrioleDB 17 Extension Dependencies |
PostgreSQL Package Dependency Analysis: PR #2146
SummaryNo packages had MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency Closure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?