feat: improve phoenix errors#2029
Merged
Merged
Conversation
Contributor
CRAP Score Report |
|
Coverage is 90.413% — feat/log-out-phoenix-errors-real-663 into main. No base build found for |
leandrocp
approved these changes
Jul 16, 2026
leandrocp
left a comment
leandrocp
left a comment
Contributor
There was a problem hiding this comment.
Just non-blocking suggestions.
| defp status_code(status) when is_integer(status), do: status | ||
| defp status_code(status), do: Plug.Conn.Status.code(status) | ||
|
|
||
| defp format_reason(_kind, %mod{__exception__: true} = reason), |
Contributor
There was a problem hiding this comment.
Old habit of matching __exception__? Nitpick but you could use https://elixir.hexdocs.pm/Kernel.html#is_exception/1 😄
Comment on lines
+44
to
+46
| assert log =~ "[error]" | ||
| assert log =~ "HttpServerError" | ||
| assert log =~ "Sent 500 response: RuntimeError - boom" |
Contributor
There was a problem hiding this comment.
Nitpick but we could do a single assert to avoid false positives:
Suggested change
| assert log =~ "[error]" | |
| assert log =~ "HttpServerError" | |
| assert log =~ "Sent 500 response: RuntimeError - boom" | |
| assert log =~ "error_code=HttpServerError [error] HttpServerError: Sent 500 response: RuntimeError - boom" |
Comment on lines
+100
to
+101
| defp status_code(status) when is_integer(status), do: status | ||
| defp status_code(status), do: Plug.Conn.Status.code(status) |
Contributor
There was a problem hiding this comment.
Suggested change
| defp status_code(status) when is_integer(status), do: status | |
| defp status_code(status), do: Plug.Conn.Status.code(status) |
https://github.com/supabase/realtime/pull/2029/changes#r3596892449
Comment on lines
+86
to
+87
| status = status_code(status) | ||
| message = "Sent #{status} response: #{format_reason(kind, reason)}" |
Contributor
There was a problem hiding this comment.
Plug.Conn.Status.code/1 already checks if value is integer.
Suggested change
| status = status_code(status) | |
| message = "Sent #{status} response: #{format_reason(kind, reason)}" | |
| message = "Sent #{Plug.Conn.Status.code(status)} response: #{format_reason(kind, reason)}" |
edgurgel
reviewed
Jul 16, 2026
| defp error_response(:token_malformed), do: {401, "The token provided is not a valid JWT"} | ||
| defp error_response(:too_many_connections), do: {429, "Too many connected users"} | ||
| defp error_response(:too_many_joins), do: {429, "Too many joins per second"} | ||
| defp error_response(_reason), do: {403, "Error connecting to Realtime"} |
Member
There was a problem hiding this comment.
Forbidden as a default reason seems wrong 🤔
edgurgel
reviewed
Jul 16, 2026
| end | ||
| end | ||
|
|
||
| describe "handle_error/2" do |
Member
There was a problem hiding this comment.
can we get integration tests for a few of these?
filipecabaco
force-pushed
the
feat/log-out-phoenix-errors-real-663
branch
from
July 17, 2026 21:18
a2f450d to
7129575
Compare
|
🎉 This PR is included in version 2.116.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
filipecabaco
added a commit
that referenced
this pull request
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
improve phoenix errors to show more information and give them more relevance