feat(storage): add the five missing Iceberg catalog capabilities - #76
Merged
Conversation
The Iceberg namespace and table splits cover create, list, load, update,
rename and delete, but the Iceberg REST Catalog exposes five more
operations that no feature id currently describes:
- GET /namespaces/{ns} load_namespace_metadata
- HEAD /namespaces/{ns} namespace_exists
- POST /namespaces/{ns}/properties update_namespace_properties
- POST /namespaces/{ns}/register register_table
- HEAD /namespaces/{ns}/tables/{t} table_exists
supabase-flutter implements all five today and has nowhere to declare
them, so they end up registered against a capability they do not
implement purely to satisfy the new-symbol check.
|
Warning Review limit reached
Next review available in: 59 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
spydon
added a commit
to supabase/supabase-flutter
that referenced
this pull request
Aug 7, 2026
Every Iceberg catalog operation now has a feature id, so loadNamespaceMetadata, namespaceExists, updateNamespaceProperties, registerTable and tableExists move out of the top-level supporting bucket into entries of their own. That also gives RegisterTableRequest and UpdateNamespacePropertiesResult a real owner, leaving nothing at the top level but genuinely shared types.
grdsdev
approved these changes
Aug 7, 2026
5 tasks
spydon
marked this pull request as ready for review
August 7, 2026 09:53
spydon
added a commit
to supabase/supabase-flutter
that referenced
this pull request
Aug 7, 2026
…nd splits (#1667) ## Summary Reconciles `sdk-compliance.yaml` with three upstream changes that have now landed in `supabase/sdk`: - **supabase/sdk#74** renamed and split several canonical feature IDs. - **supabase/sdk#75** separated symbol *evidence* from symbol *coverage*, adding `supporting_symbols`. - **supabase/sdk#76** added the five Iceberg catalog capabilities that #74's split left without an ID. ### Renames and merges - `auth.sign_in.reset_password` → `auth.sign_in.send_password_reset_email` - `realtime.channel.send` → `realtime.channel.broadcast` - `storage.file_buckets.list_files_paginated` merged into `list_files` - `storage.analytics.iceberg_namespace` split into `create_namespace` / `list_namespaces` / `delete_namespace` - `storage.analytics.iceberg_table` split into `create_table` / `list_tables` / `load_table` / `update_table` / `rename_table` / `delete_table` ### New capabilities declared `load_namespace_metadata`, `namespace_exists`, `update_namespace_properties`, `register_table`, `table_exists`. ## Why the Iceberg entries look the way they do Splitting two bundled entries into fifteen raises the question of which symbols belong where. The Iceberg surface is 352 symbols, only 18 of which are catalog entry points; the rest are option types, result types, the schema and type model, and the exception hierarchy. `symbols` now holds **only** the methods a caller invokes, because the drift check treats every name in it as evidence the capability exists. Everything else sits under `supporting_symbols`, which counts for new-symbol coverage without claiming to implement anything. Owners for the supporting types are derived from the source rather than assigned by hand: build the type graph from `packages/storage_client/lib/src/iceberg/`, including subtype edges since a signature naming a sealed base reaches every variant a caller can pass, then ask which entry points reach each type. A type reachable from exactly one feature belongs to that feature. | | count | |---|---| | Sole natural owner | 37 of 67 | | Genuinely shared across several features | 20 | | Reachable from no entry point (thrown, not passed) | 10 | So all 28 `*Update` and `Assert*` classes land on `update_table`, `ListTablesOptions`/`ListTablesResult` on `list_tables`, `RegisterTableRequest` on `register_table`. The schema and type model and the exception hierarchy stay in the top-level `supporting_symbols` list, which is the honest answer rather than a coin flip. The alternative was to replicate the full 330-symbol list across all six table IDs and the 22-symbol list across all three namespace IDs (+1729 lines, as in the now-closed #1666). That inflates what the file claims is implemented, fans drift findings across features that do not own the symbol, and leaves attribution arbitrary, since `buildSymbolIndex` last-wins on collision. Under that shape only 2 of 9 split features resolved to their own entry point; here it is 9 of 9. ## Test plan Validated against current `supabase/sdk@main`, with #74, #75 and #76 all merged: - [x] `validate-compliance`: `OK — compliance file is valid.` Two features remain undeclared (`postgres_changes_multiple_filters`, `error_codes`); both are pre-existing and out of scope here. - [x] `check-drift` against symbols extracted with the real Dart extractor: `✅ No capability matrix drift detected.` - [x] `check-api-symbols`: all public API accounted for; 887 symbols covered, unchanged from before this PR. - [x] Verified no unintended edits: every feature outside the rename and split scope is byte-identical to `main` after re-serialization. - [x] CI re-run after the upstream merges: `Validate compliance file` and `Check public API against capability matrix` both green. No SDK code changes, only capability declarations. Context: [SDK-1439](https://linear.app/supabase/issue/SDK-1439) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Improvements** * Standardized capability names for password reset and realtime broadcast functionality. * Clarified storage file listing capabilities, including pagination and sorting support. * Added more granular capability definitions for Iceberg namespaces and tables. * Consolidated shared Iceberg models, errors, catalog access, and supporting symbols for more consistent capability descriptions. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#74 splits the two bundled Iceberg entries into nine per-operation feature IDs: create, list and delete for namespaces; create, list, load, update, rename and delete for tables.
The Iceberg REST Catalog exposes five more operations that no feature ID describes:
GET /namespaces/{ns}storage.analytics.load_namespace_metadataHEAD /namespaces/{ns}storage.analytics.namespace_existsPOST /namespaces/{ns}/propertiesstorage.analytics.update_namespace_propertiesPOST /namespaces/{ns}/registerstorage.analytics.register_tableHEAD /namespaces/{ns}/tables/{table}storage.analytics.table_existsThis is not theoretical. supabase-flutter implements all five today:
Because
check-api-symbolsrequires every public symbol to be registered somewhere, and there is no ID that fits, those methods currently have to be declared against a capability they do not implement just to keep CI green. That is visible in supabase/supabase-flutter#1666, where the whole Iceberg symbol list is replicated across every split ID, and in supabase/supabase-flutter#1667, where they sit in a supporting bucket with a comment explaining they have no home.Splitting a bundled capability into per-verb IDs is only lossless if the verbs cover the surface. These five are the gap.
Change
Adds the five feature IDs to
capabilities/storage.yaml, in the existinganalyticsgroup, following the descriptions already used for the split entries.No SDK currently declares anything under
storage.analytics, so every SDK except Flutter is unaffected. They staynot_implementedby omission, which is accurate.Test plan
npm run validate:OK — capability matrix is valid.storage.analyticscapabilities, so nothing regresses there.Related