fix: update acceptance tests for staging#1208
Open
itslenny wants to merge 2 commits into
Open
Conversation
Coverage Report for CI Build 29267338856Coverage increased (+0.005%) to 79.381%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
itslenny
force-pushed
the
lenny/update-acceptance-tests-for-staging
branch
3 times, most recently
from
ad50cad to
2525db3
Compare
itslenny
force-pushed
the
lenny/update-acceptance-tests-for-staging
branch
3 times, most recently
from
e354c44 to
72a5211
Compare
itslenny
force-pushed
the
lenny/update-acceptance-tests-for-staging
branch
2 times, most recently
from
a3588fb to
af97392
Compare
fenos
reviewed
Jul 13, 2026
| await cleanupRestResources(bucketName, [], client) | ||
| }) | ||
|
|
||
| it('purges an object cache entry', async () => { |
Contributor
There was a problem hiding this comment.
i think we can use it.skipIf(!isCdnEdge) helper so that we can remove the ifs isCdnEdge
Contributor
Author
There was a problem hiding this comment.
I'd have to add separate tests for that to work. These tests hit the purge endpoints in both local and remote mode. Only in remote mode can we test if the purge actually worked. So, rather than having fully separate remote/local tests I am just conditionally doing the check on remote only before/after the purge.
fenos
reviewed
Jul 13, 2026
itslenny
force-pushed
the
lenny/update-acceptance-tests-for-staging
branch
from
af97392 to
9001287
Compare
ferhatelmas
reviewed
Jul 13, 2026
|
|
||
| ```bash | ||
| mkdir -p data | ||
| STORAGE_BACKEND=file ACCEPTANCE_ENABLE_RENDER=true npm run acceptance -- --profile full acceptance/specs/cdn-render.test.ts |
Member
There was a problem hiding this comment.
Suggested change
| STORAGE_BACKEND=file ACCEPTANCE_ENABLE_RENDER=true npm run acceptance -- --profile full acceptance/specs/render.test.ts |
ferhatelmas
reviewed
Jul 13, 2026
Comment on lines
+174
to
+182
| await client.request('GET', purgedRoute, { | ||
| expectedCacheStatus: 'MISS', | ||
| expectedStatus: 200, | ||
| }) | ||
| await client.request('GET', purgedRoute, { | ||
| expectedCacheStatus: 'HIT', | ||
| expectedStatus: 200, | ||
| retries: CACHE_RETRIES, | ||
| }) |
Member
There was a problem hiding this comment.
repeated many times, this could be be a helper
ferhatelmas
reviewed
Jul 13, 2026
| await delay(SIGNED_EXPIRES_IN_S * 1000) | ||
|
|
||
| const expectedError = isSigned | ||
| ? { statusCode: '400', error: 'InvalidJWT' } |
Member
There was a problem hiding this comment.
I think we should test not expiring token to test real cache invalidation
ferhatelmas
reviewed
Jul 13, 2026
| await delay(SIGNED_EXPIRES_IN_S * 1000) | ||
|
|
||
| const expectedError = isSigned | ||
| ? { statusCode: '400', error: 'InvalidJWT' } |
Member
There was a problem hiding this comment.
similar non-expiring token should be used here as well
ferhatelmas
reviewed
Jul 13, 2026
| { | ||
| destructive: true, | ||
| profiles: ['full'], | ||
| requires: ['cdn'], |
Member
There was a problem hiding this comment.
hits to render but doesn't require it
ferhatelmas
reviewed
Jul 13, 2026
|
|
||
| // check invalid token / access denied | ||
| if (isSigned) { | ||
| // const { route } = items[0] |
Member
There was a problem hiding this comment.
Suggested change
| // const { route } = items[0] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Acceptance tests cannot run against staging environment
What is the new behavior?
Adjust acceptance tests so they can be run against staging
Add CDN Edge tests to test Smart CDN and cache purge behavior end to end