chore: cleanup multigres workaround for statement timeout#1228
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a Multigres-specific workaround in tests by switching statement timeout verification from SHOW statement_timeout to current_setting('statement_timeout', ...), aligning behavior across supported Postgres engines.
Changes:
- Update
storage-pg-dbtest helper to readstatement_timeoutviacurrent_setting. - Update
pg-connectiontest to assert transaction-localstatement_timeoutviacurrent_settingand remove the extraSHOWquery/workaround comments.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/test/storage-pg-db.test.ts | Reads statement_timeout via current_setting for consistent cross-engine behavior in bucket metadata tests. |
| src/test/pg-connection.test.ts | Verifies scope + statement timeout using a single current_setting-based query and removes the prior SHOW workaround. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report for CI Build 29320846308Coverage increased (+0.09%) to 79.466%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
via current_setting instead of top level show. Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
ferhatelmas
force-pushed
the
ferhat/cleanup-multigres
branch
from
4d7ae71 to
6285d4b
Compare
fenos
approved these changes
Jul 14, 2026
Contributor
|
Awesome! Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
chore
What is the current behavior?
Multigres keeps returning zero for statement timeout via
current_settingand required top levelshowinstead.What is the new behavior?
multigres/multigres#1258 fixed the problem so dropping the workaround and making it consistent for engines.
Additional context
Related to #1154 (comment) where the original bug was found.