feat(auth): send PKCE code_challenge in updateUser when changing email#1601
Conversation
|
Warning Review limit reached
Next review available in: 12 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
Sequence Diagram(s)sequenceDiagram
participant GoTrueClient
participant AuthServer
participant Mailpit
GoTrueClient->>AuthServer: Update email with PKCE challenge
AuthServer->>Mailpit: Send verification email
GoTrueClient->>Mailpit: Retrieve verification code
GoTrueClient->>AuthServer: Exchange code for session
AuthServer-->>GoTrueClient: Return session with updated email
Suggested labels: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Under the PKCE flow,
updateUser({ email })now generates a PKCE code verifier and sends the correspondingcode_challenge/code_challenge_methodin the request body, mirroring whatresend()andgetSSOSignInUrlalready do. This lets an email change started under PKCE complete viaexchangeCodeForSession().The fields are only added when an email is being changed, so no public API surface or return type changes. Non-PKCE flows are unaffected (the challenge is
null).Outcome
implemented
Reference
resend()PKCE work (SDK-1023).Compliance matrix
auth.session.update_user→implemented(waspartially_implemented).Tests
packages/gotrue/test/otp_mock_test.dart: PKCE email change includes the code challenge, non-email updates omit it, and implicit flow omits it.Closes SDK-1318