Skip to content

Use Link component instead of native a element in marketplace settings - #47720

Merged
joshenlim merged 1 commit into
masterfrom
chore/use-link-instead-of-a-element-in-marketplace
Jul 8, 2026
Merged

Use Link component instead of native a element in marketplace settings#47720
joshenlim merged 1 commit into
masterfrom
chore/use-link-instead-of-a-element-in-marketplace

Conversation

@joshenlim

@joshenlim joshenlim commented Jul 8, 2026

Copy link
Copy Markdown
Member

Context

Just a tiny one to use Link instead of a tags to render links in Marketplace settings

The a tags would otherwise drop the /dashboard URL prefix on staging and prod

Summary by CodeRabbit

  • Bug Fixes
    • Improved navigation in the integrations resource group section by using app-native links for management actions, making links behave more consistently across the interface.

@joshenlim
joshenlim requested a review from a team as a code owner July 8, 2026 01:52
@vercel

vercel Bot commented Jul 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
studio-self-hosted Ready Ready Preview, Comment Jul 8, 2026 1:56am
studio-staging Ready Ready Preview, Comment Jul 8, 2026 1:56am
5 Skipped Deployments
Project Deployment Actions Updated (UTC)
studio Ignored Ignored Jul 8, 2026 1:56am
design-system Skipped Skipped Jul 8, 2026 1:56am
docs Skipped Skipped Open in v0 Jul 8, 2026 1:56am
ui-library Skipped Skipped Jul 8, 2026 1:56am
zone-www-dot-com Skipped Skipped Open in v0 Jul 8, 2026 1:56am

Request Review

@supabase

supabase Bot commented Jul 8, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project xguihxuzqibwxjnimxev because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7927d5f0-b69a-4f6e-9c6e-b03211db0b2d

📥 Commits

Reviewing files that changed from the base of the PR and between 561e43b and 8684568.

📒 Files selected for processing (1)
  • apps/studio/components/interfaces/Integrations/Integration/ConnectedResourceGroupSection.tsx

📝 Walkthrough

Walkthrough

This change replaces plain anchor <a> elements with Next.js Link components for navigating to a group's manage action href, in both the missing-resource and per-item action areas of ConnectedResourceGroupSection.tsx, along with the corresponding import addition.

Changes

Link navigation update

Layer / File(s) Summary
Replace anchors with Next.js Link
apps/studio/components/interfaces/Integrations/Integration/ConnectedResourceGroupSection.tsx
Adds Link import and swaps plain <a> elements for Link components pointing to group.manageAction.href in both the missing-resource and per-item action rendering paths.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning Only a Context section is provided; the template requires several missing sections, including change type, current behavior, and new behavior. Add the missing template sections: CONTRIBUTING.md confirmation, change type, current behavior/issues, new behavior, and any additional context or screenshots.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: replacing native links with Next.js Link in marketplace settings.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/use-link-instead-of-a-element-in-marketplace

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🎭 Playwright Test Results

passed  231 passed
flaky  1 flaky
skipped  5 skipped

Details

stats  237 tests across 27 suites
duration  4 minutes, 1 second
commit  8684568

Flaky tests

Features › rls-policies.spec.ts › RLS Policies › Table editor RLS badge › shows Unrestricted badge when RLS is disabled for public table

Skipped tests

Features › auth-users.spec.ts › should show web3 users as enabled when the matching web3 provider is enabled
Features › sql-editor.spec.ts › SQL Editor › snippet favourite works as expected
Features › sql-editor.spec.ts › SQL Editor › share with team works as expected
Features › sql-editor.spec.ts › SQL Editor › folders works as expected
Features › sql-editor.spec.ts › SQL Editor › other SQL snippets actions work as expected

@alaister alaister left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joshenlim
joshenlim merged commit b3c98c1 into master Jul 8, 2026
34 checks passed
@joshenlim
joshenlim deleted the chore/use-link-instead-of-a-element-in-marketplace branch July 8, 2026 04:11
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Braintrust eval report

Assistant (master-1783484026)

Score Average Improvements Regressions
Knowledge Usage 92.3% (+0pp) 1 🟢 2 🔴
SQL Identifier Quoting 100% (+0pp) - -
SQL Validity 100% (+0pp) - -
Tool Usage 72.5% (+4pp) 2 🟢 2 🔴
Time_to_first_token 3.54tok (+0.38tok) 5 🟢 24 🔴
Llm_calls 2.84 (+0) 8 🟢 14 🔴
Tool_calls 2.91 (+0.2) 12 🟢 9 🔴
Errors 5.22 (+0) 4 🟢 5 🔴
Llm_errors 0 (+0) - -
Tool_errors 0 (+0) - -
Prompt_tokens 21309.91tok (+1633.8tok) 10 🟢 15 🔴
Prompt_cached_tokens 7703.54tok (+717.98tok) 14 🟢 12 🔴
Prompt_cache_creation_tokens 0tok (+0tok) - -
Prompt_cache_creation_5m_tokens 0tok (+0tok) - -
Prompt_cache_creation_1h_tokens 0tok (+0tok) - -
Completion_tokens 619.55tok (+23.75tok) 11 🟢 17 🔴
Completion_reasoning_tokens 101.22tok (+0.26tok) 15 🟢 11 🔴
Total_tokens 21929.46tok (+1657.55tok) 11 🟢 18 🔴
Estimated_cost 0$ (+0$) 10 🟢 17 🔴
Duration 19.53s (+2.47s) 6 🟢 23 🔴
Llm_duration 12.47s (+0.61s) 12 🟢 17 🔴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants