fix: replace tracked change bubble [SD-484] - #1135
Merged
Merged
Conversation
palmer-cl
commented
Oct 15, 2025
palmer-cl
commented
Collaborator
- When replacing text, pass insertion ID to deletion to link with the same ID
- Add tests for single insertion, single deletion and replace
palmer-cl
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR fixes tracked change behavior for replace operations by ensuring that both insertion and deletion marks share the same ID, which is necessary for proper change tracking visualization.
- Modify
markDeletionto accept an optional ID parameter for linking with insertions - Update
replaceStepto pass the insertion mark ID to the deletion operation - Add comprehensive test coverage for replace, insertion-only, and deletion-only scenarios
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
trackChangesHelpers.test.js |
Adds comprehensive test suite for replace operations and ID sharing behavior |
replaceStep.js |
Passes insertion mark ID to deletion operation for linking |
markDeletion.js |
Accepts optional ID parameter and uses it when provided |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
🎉 This PR is included in version 0.25.0-next.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
superdocbot Bot
pushed a commit
that referenced
this pull request
Oct 15, 2025
# [0.25.0](v0.24.0...v0.25.0) (2025-10-15) ### Bug Fixes * replace (addition/deletion) tracked change bubble ([#1135](#1135)) ([cd8b480](cd8b480)) * toolbar font-size when multiple selected ([#1139](#1139)) ([234f8e1](234f8e1)) ### Features * allow customizing of tracked change permissions ([#1132](#1132)) ([1078801](1078801))
|
🎉 This PR is included in version 0.25.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.