Skip to content

fix: toolbar font-size when multiple selected - #1139

Merged
harbournick merged 1 commit into
mainfrom
artem-SD-573
Oct 15, 2025
Merged

fix: toolbar font-size when multiple selected#1139
harbournick merged 1 commit into
mainfrom
artem-SD-573

Conversation

@artem-harbour

Copy link
Copy Markdown
Contributor

Increase input size.
Screenshot 2025-10-15 at 17 09 20

Empty input if multiple sizes are selected.
Screenshot 2025-10-15 at 17 09 46

@artem-harbour artem-harbour self-assigned this Oct 15, 2025
@linear

linear Bot commented Oct 15, 2025

Copy link
Copy Markdown

@harbournick harbournick left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one issue with isMultiple. It strikes me that the same "issue" we're fixing here happens with any other mark and toolbar button: for example, selections that have both bold and not bold text highlighted. Or different fonts.

I mention it here as I believe there may be a follow-on "generalized" version of this ticket which may affect the approach.

Comment thread packages/super-editor/src/components/toolbar/super-toolbar.js Outdated

@harbournick harbournick left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harbournick
harbournick merged commit 234f8e1 into main Oct 15, 2025
7 checks passed
@harbournick
harbournick deleted the artem-SD-573 branch October 15, 2025 21:26
@superdocbot

superdocbot Bot commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.25.0-next.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

superdocbot Bot pushed a commit that referenced this pull request Oct 15, 2025
# [0.25.0](v0.24.0...v0.25.0) (2025-10-15)

### Bug Fixes

* replace (addition/deletion) tracked change bubble ([#1135](#1135)) ([cd8b480](cd8b480))
* toolbar font-size when multiple selected ([#1139](#1139)) ([234f8e1](234f8e1))

### Features

* allow customizing of tracked change permissions ([#1132](#1132)) ([1078801](1078801))
@superdocbot

superdocbot Bot commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

superdoc-bot Bot pushed a commit that referenced this pull request Jul 31, 2026
…hen (#1139)

Co-authored-by: Artem Nistuley <artem@superdoc.dev>

Ported-From-Source-Repo: superdoc/orbit
Ported-From-Source-Commit: d91ef133c6e77551d777df5007250be7d5e846c0
Ported-Public-Prefix: superdoc/public
superdoc-orbit Bot pushed a commit that referenced this pull request Aug 2, 2026
### Chores

- 0.22.2 [skip ci]
- 1.45.1 [skip ci]

### Changes

- Merge remote-tracking branch 'origin/main' into merge/main-into-stable-2026-08-02

### Bug Fixes

- stop V1 claiming the npm dist-tags owned by V2 (#1207)
- v1 w:ins/w:del lose tracking when a run begins with w:noBreakHyphen (#1139)
superdoc-orbit Bot pushed a commit that referenced this pull request Aug 2, 2026
### Chores

- 1.21.3 [skip ci]
- 0.22.2 [skip ci]
- 1.45.1 [skip ci]

### Changes

- Merge remote-tracking branch 'origin/main' into merge/main-into-stable-2026-08-02

### Bug Fixes

- stop V1 claiming the npm dist-tags owned by V2 (#1207)
- v1 w:ins/w:del lose tracking when a run begins with w:noBreakHyphen (#1139)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants