Introduce <#raw> and deprecate <#Raw> #377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malian
force-pushed
the
introduce-raw-macro
branch
from
c470b90 to
7a31ad2
Compare
lnr0626
reviewed
May 7, 2021
Collaborator
lnr0626
left a comment
lnr0626
left a comment
There was a problem hiding this comment.
only one of the two suggestions would need to be applied, but if we keep the defp handle_macro_body("</#raw" variant, we should also add some tests to verify the columns are correct after a closing </#raw> tag
msaraiva
approved these changes
May 7, 2021
lib/surface/components/raw.ex
Outdated
| def expand(_attributes, children, meta) do | ||
| message = """ | ||
| using <#Raw> to not translate any of its contents has been deprecated and will be \ | ||
| removed in future versions. |
Member
There was a problem hiding this comment.
I'd just go with:
using <#Raw> has been deprecated and will be removed in future versions.
Hint: ...
lnr0626
added a commit
to lnr0626/surface
that referenced
this pull request
May 11, 2021
* surface-next: Remove `phx_` prefix from props (surface-ui#384) Remove code for embedded interpolation inside strings Introduce <#unless> (surface-ui#376) Introduce the concept of root properties (surface-ui#382) Warn on invalid prop/data defaults (surface-ui#374) Deprecated unquoted strings (surface-ui#379) Convert embedded interpolation (surface-ui#380) Introduce <#raw> and deprecate <#Raw> (surface-ui#377)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #340