Skip to content

Convert embedded interpolation #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2021
Merged

Convert embedded interpolation #380

merged 1 commit into from
May 8, 2021

Conversation

@msaraiva
Copy link
Member

@msaraiva msaraiva commented May 8, 2021

Convert id="id_{{@id}}" into id={"id_#{@id}"}

@msaraiva msaraiva requested a review from Malian May 8, 2021 11:50
@msaraiva msaraiva merged commit a9060f4 into surface-next May 8, 2021
@msaraiva msaraiva deleted the ms-convert-embedded-interpolation branch May 8, 2021 14:09
lnr0626 added a commit to lnr0626/surface that referenced this pull request May 11, 2021
@lnr0626
Merge branch 'surface-next' into lr-parse-engine-playground
f11a257 
* surface-next:
  Remove `phx_` prefix from props (surface-ui#384)
  Remove code for embedded interpolation inside strings
  Introduce <#unless> (surface-ui#376)
  Introduce the concept of root properties (surface-ui#382)
  Warn on invalid prop/data defaults (surface-ui#374)
  Deprecated unquoted strings (surface-ui#379)
  Convert embedded interpolation (surface-ui#380)
  Introduce <#raw> and deprecate <#Raw> (surface-ui#377)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Malian Malian Malian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@msaraiva @Malian