Remove phx_ prefix from props
#384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malian
approved these changes
May 9, 2021
lnr0626
added a commit
to lnr0626/surface
that referenced
this pull request
May 11, 2021
* surface-next: Remove `phx_` prefix from props (surface-ui#384) Remove code for embedded interpolation inside strings Introduce <#unless> (surface-ui#376) Introduce the concept of root properties (surface-ui#382) Warn on invalid prop/data defaults (surface-ui#374) Deprecated unquoted strings (surface-ui#379) Convert embedded interpolation (surface-ui#380) Introduce <#raw> and deprecate <#Raw> (surface-ui#377)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
phx_prefix from props for consistent naming of props in builtin components.Only affects the
phx_feedback_forprop in<ErrorTag>