-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support of filter prop to swagger-ui-react #7547
add support of filter prop to swagger-ui-react #7547
Conversation
# This is the 1st commit message: add support of filter prop to swagger-ui-react # This is the commit message swagger-api#2: #`null` replaced with `false`
88284e8
to
408bc1d
Compare
Co-authored-by: Mahtis Michel <mathis.michel@outlook.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndrewCeM thanks for contributing!
Please have a look at my code review comments before we move forward with the PR.
Co-authored-by: Vladimir Gorej <vladimir.gorej@gmail.com>
Co-authored-by: Vladimir Gorej <vladimir.gorej@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're looking great here. Thank you for contributing.
We'll merge this as soon as v4 effort lands in master (probably next week).
https://swagger.io/blog/api-design/what%E2%80%99s-ahead-for-swaggerui-v4-and-swaggereditor-v4/
please build |
please build |
Added possibility to pass filter prop to
swagger-ui-react
component, which allows filtering by tags.Motivation and Context
swagger-ui-react
doesn't support all implemented functionalities of theswagger-ui
due to the fact that not all of the props are allowed to pass. I need a possibility to filter swagger docs by tags.Fixes #7546
How Has This Been Tested?
I made fork of the
swagger-ui
and was testing it with applied changes on my local machine.Screenshots (if appropriate):
My PR contains...
swagger-ui-react
code change.filter
prop was added to the propTypes and is passed to the swaggerUi as prop. It's set only once, on mount.swagger-ui-react
readme.md updated;src/
is unmodified: changes to documentation, CI, metadata, etc.)package.json
)My changes...
Documentation
Automated tests