WasmParser: Stop taking FilePath in detectWasmFileType - #368
Merged
Conversation
The caller usually uses a `FileDescriptor` to parse the file after detecting the file type, so opening fd inside the detection function is wasteful. We can instead move the fd opening to the caller. Also this reduces system dependencies in the `WasmParser` module.
kateinoigakukun
force-pushed
the
katei/stop-open-in-magic-detection
branch
from
June 29, 2026 21:03
d1b421c to
5f3078d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The caller usually uses a
FileDescriptorto parse the file after detecting the file type, so opening fd inside the detection function is wasteful. We can instead move the fd opening to the caller. Also this reduces system dependencies in theWasmParsermodule.