Task/g109 optional duration for mosaic transaction #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e methods + rewrite tests to add 0 maxFee
…e classes overloads
…tp.getTransactionEffectiveFee()
…ed getTransactionEffectiveFee implementation
…rg911/nem2-sdk-typescript-javascript into task/g4_check_act_has_all_sosignatories
…rg911/nem2-sdk-typescript-javascript into task/g4_check_act_has_all_sosignatories
…rg911/nem2-sdk-typescript-javascript into task/g4_check_act_has_all_sosignatories
modify multisig account (removal)
added extra check on recipient.id
Fixed trailing comma in tslint
…signatories Task/g4 check aggregate complete transaction has all cosignatories
Fixed trailing comma in tslint
…github.com:rg911/nem2-sdk-typescript-javascript into task/g109_optional_duration_for_mosaic_transaction
Fixed a few lint issues on EncryptedMessage and test Fixed failed test on EncryptedMessage spec
Fixed trailing comma in tslint
Fixed trailing comma in tslint
Fixed trailing comma in tslint
Fixed trailing comma in tslint
Fixed a few lint issues on EncryptedMessage and test Fixed failed test on EncryptedMessage spec
…github.com:rg911/nem2-sdk-typescript-javascript into task/g109_optional_duration_for_mosaic_transaction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #109
Changed to make
Durationoptional on MosaicDefinition transaction