Task/g204 sign transaction given signatures #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `restrictable` in MosaicProperties - Added MosaicGlobalRestriction and MosaicAddressRestriction transactions - Added unit tests and e2e tests for the 2 new txs - Added serialization handlers - Fixed couple of serialization bugs with MosaicId
- Fixed signTransactionGivenSignatures bug - Added e2e test for signTransactionGivenSignatures - Improved unit test for signTransactionGivenSignatures - Fixed typo
Pull Request Test Coverage Report for Build 588
💛 - Coveralls |
evias
approved these changes
Jul 16, 2019
| expect(signedTransaction.payload.indexOf(accountCarol.publicKey) > -1).to.be.true; | ||
|
|
||
| // To make sure that the new cosign method returns the same payload & hash as standard cosigning | ||
| const standardCosignedTransaction = aggregateTransaction |
[Elephant 2] Mosaic Restriction
Fixed compatibility issue on new rxjs version
…compatibility Revert "Fixed compatibility issue on new rxjs version"
- Fixed signTransactionGivenSignatures bug - Added e2e test for signTransactionGivenSignatures - Improved unit test for signTransactionGivenSignatures - Fixed typo
…:rg911/nem2-sdk-typescript-javascript into task/g204_signTransactionGivenSignatures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fixed in newly introduced
signTransactionGivenSignatures(). It is noticed that the signed transaction's signature mismatched with standard cosign methods after appliedgenerationHash.this PR:
signTransactionPayloadsignTransactionGivenSignatures()signTransactionPayload**Process flow changes
It was initially proposed to generate 'plain` (empty signature & signer) payload by the initiator and passed to cosigners. However, the first half of the initiator's signature is required to validate co-signatures. So it is changed that:
signTransactionPayloadmethod and sends it back to AlicesignTransactionGivenSignatures, and announces the transactionIssue : #204