Bump ChromeDriver to v78, ignore unmatched errors under phpstan #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@dunglas This addresses two separate issues that are causing all Travis builds to fail and which will resolve Travis build errors for all projects that depend on panther. |
Merged
Member
|
Thanks @webignition! |
dunglas
added a commit
that referenced
this pull request
Dec 28, 2020
Bump ChromeDriver to v78, ignore unmatched errors under phpstan
nicolas-grekas
pushed a commit
that referenced
this pull request
Jan 18, 2021
Bump ChromeDriver to v78, ignore unmatched errors under phpstan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #245
Fixes #246
This PR addresses two separate issues that are causing/will cause Travis builds to fail. These issues need to be addressed simultaneously to result build failures.
#245 relates to Travis now installing Chrome 78 which requires an update of ChromeDriver. Travis previously installed Chrome 76 then Chrome 77 both of which were compatible with the version of ChromeDriver being used.
#246 relates to phpstan under PHP 7.3 failing due to there being unmatched ignored error patterns (which are required when invoking phpstan under PHP 7.1 or 7.2).