Skip to content

Conversation

@andreybolonin
Copy link
Contributor

add symfony5 compatibility

composer.json Outdated
"symfony/http-client": "^4.3",
"symfony/browser-kit": "^4.3|^5.0",
"symfony/dom-crawler": "^4.3|^5.0",
"symfony/http-client": "^4.3|^5.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be consistent to use the same style as below: double pipe+spaces around.

@domis86 domis86 mentioned this pull request Oct 25, 2019
@manzolo
Copy link

manzolo commented Oct 25, 2019

To pass tests it is necessary to solve this problem #245

@webignition
Copy link

PR #248 fixes #245 and #246 which are both needed to be resolved for this build to pass

@dunglas dunglas merged commit 878d880 into symfony:master Oct 28, 2019
@dunglas
Copy link
Member

dunglas commented Oct 28, 2019

Thanks @andreybolonin

@andreybolonin
Copy link
Contributor Author

@dunglas thx

dunglas added a commit that referenced this pull request Dec 28, 2020
nicolas-grekas pushed a commit that referenced this pull request Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants