fix: Resolve full solution builds failing on first runs.#5187
Merged
Conversation
Chicken-Bones
requested changes
Jun 6, 2026
Chicken-Bones
left a comment
Chicken-Bones
left a comment
Member
There was a problem hiding this comment.
Most of the changes seem good. I'd just like to do some more diagnostics to make sure we get it right this time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This slightly hacky patch fixes the following type of compilation error that can be encountered by simply wiping the destination folder and running
dotnet build tModLoader.sln:Changes
/tModLoader.targetsfile is updated to evaluatetMLMod.targetsdirectly fromsrc/.../release_targets, removing the dependency cycle between evaluations and builds. Paths still point to the destination, but that should be fine as they are not fully acted upon before builds. In this process,tMLMod.targets's paths are modified to only be set if they are missing.Alternative approaches
/tModLoader.targetsalready adds project references for TML, ReLogic and FNA, that trend might be able to be continued with it changed to copy all of TML's original references to the child projects that use it. But that would be even more hacky.