[1.4.5] Ported tile-entity updates#5207
Merged
Merged
Conversation
Member
|
Please remove the tests, they don't add much value relative to their maintenance cost. We will discuss the default for |
Member
|
You can initialize the default value of |
Chicken-Bones
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the bug?
Terraria 1.4.5 only updates tile entities registered in
TileEntity.UpdateEntities.tModLoader directly added and removed modded tile entities from
ByIDandByPosition, bypassing the new registration logic. Consequently, modded tile entities were not registered for updates.How did you fix the bug?
Modded tile entities now require updates by default, preserving their previous behavior.
Placement, loading, and removal now use
TileEntity.AddandTileEntity.Remove, keepingUpdateEntities,ByID, andByPositionsynchronized.Documentation and tests were added for both updating tile entities and tile entities that opt out by setting
RequiresUpdatestofalse.Are there alternatives to your fix?
Mods could be required to set
RequiresUpdatesthemselves, but this would silently break existing tile entities.tModLoader could maintain a separate update loop, but using Terraria's existing registration methods avoids duplicating update behavior.