cmd/tailscale/cli: fix plain TCP serve status#20451
Merged
Merged
Conversation
Do not label plain TCP forwarding as TLS over TCP. Render status annotations only when TLS termination or PROXY protocol is configured. Fixes tailscale#20367 Change-Id: I3f6507365ceedc2950451810e9715afb85176fc5 Signed-off-by: coyaSONG <66289470+coyaSONG@users.noreply.github.com>
coyaSONG
force-pushed
the
fix/serve-plain-tcp-status
branch
from
July 14, 2026 16:09
31cd027 to
def1758
Compare
This comment was marked as spam.
This comment was marked as spam.
Contributor
|
Great work @coyaSONG! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20367
Plain TCP forwarding currently initializes its output annotation as "TLS over TCP". Build annotations only from configured behavior so plain TCP has no TLS label, while TLS termination and PROXY protocol remain clearly identified.
The existing service TCP output test now covers the reported plain-TCP case.
Testing: