perf: Optimize hot paths in utility functions #19229
Closed
+119
−61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identified and eliminated performance bottlenecks in frequently-called utility functions during CSS processing.
Changes
String operations
isColor(): SkiptoLowerCase()when input contains no uppercase chars (most common case)convertUnderscoresToWhitespace(): Early return when no underscores presentallVariablesAreUsed(): Replace RegExp creation in loop with string methodsRedundant checks
expandSequence(): Remove duplicate numeric validation (already guaranteed by parent regex)hasMathFn(): Avoid template string creation, check all occurrences not just firstData structure improvements
Set.has()inisGenericName(),isAbsoluteSize(),isLineWidth(),isBackgroundPosition()Example optimization:
Impact: 11 functions optimized across 7 files. Reduces allocations and unnecessary work in paths called millions of times during builds.
Original prompt