Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThis pull request updates version ranges across multiple package manifests and the root package.json (devDependencies and several runtime dependencies), updates pnpm-workspace.yaml catalog entries, adds package-level TypeScript config overrides setting compilerOptions.verbatimModuleSyntax to false in several packages, and modifies packages/@tailwindcss-upgrade/src/index.ts to guard against non‑progressing parent-directory traversal. No package exports, public APIs, scripts, or other package metadata were changed. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Line 60: The TypeScript upgrade in package.json to "^6.0.3" introduces
breaking changes incompatible with the current tsup 8.5.1; either bump tsup to a
TS6-compatible release or add a temporary tsconfig.json flag
"ignoreDeprecations": "6.0" to suppress the deprecation errors, then re-run
builds and DTS generation; additionally, audit files with `@ts-expect-error` (for
example instrumentation.ts where Symbol.dispose is suppressed) and fix or
re-evaluate those suppressions to satisfy TS6 stricter checks.
In `@packages/`@tailwindcss-upgrade/package.json:
- Around line 34-35: The globby upgrade changes gitignore scope and may cause
the CSS-discovery call in the CSS file discovery block of
packages/@tailwindcss-upgrade/src/index.ts (the code that invokes globby to find
CSS files around lines 99–102) to exclude files unexpectedly; reproduce by
running the discovery against a repo with parent .gitignore rules and add a
unit/integration test asserting the previously-found CSS files are returned,
then if files are missing fix the globby options: either set gitignore:false to
keep prior behavior or explicitly set gitignoreRoots to the search path (e.g.,
the inputDir) in the globby call so parent .gitignore files aren’t applied, and
update the test to lock the expected behavior.
In `@pnpm-workspace.yaml`:
- Line 12: Replace the non-existent webpack version specifier by updating the
dependency entry for "webpack" from "^5.106.2" to a valid existing version such
as "^5.106.1" (or another specific 5.x version you want to pin), ensuring the
package constraint references an available release.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: e5a40ed5-df15-4e1d-a1d9-778fc20b216e
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (9)
package.jsonpackages/@tailwindcss-browser/package.jsonpackages/@tailwindcss-cli/package.jsonpackages/@tailwindcss-node/package.jsonpackages/@tailwindcss-postcss/package.jsonpackages/@tailwindcss-standalone/package.jsonpackages/@tailwindcss-upgrade/package.jsonpackages/tailwindcss/package.jsonpnpm-workspace.yaml
a62a243 to
cfd7809
Compare
TypeScript 5.9 rejects the .cts compatibility entrypoints during DTS generation when verbatimModuleSyntax is enabled. Disable it only in packages that intentionally mix ESM imports with CommonJS exports so the build can keep producing both module formats.
b05d050 to
e536d4f
Compare
ee150ab to
54b8de2
Compare
This PR bumps dependencies in all the packages, typically just bumping to the latest patch release.
Closes: #19936
Closes: #19917
Closes: #19899
Closes: #19897
Closes: #19845
Closes: #19832
Closes: #19967
Closes: #19968
Test plan
[ci-all] to verify Linux, Windows and macOS