Skip to content

Bump NAPI related dependencies#19982

Merged
RobinMalfait merged 4 commits intomainfrom
chore/bump-napi-dependencies
Apr 26, 2026
Merged

Bump NAPI related dependencies#19982
RobinMalfait merged 4 commits intomainfrom
chore/bump-napi-dependencies

Conversation

@RobinMalfait
Copy link
Copy Markdown
Member

This PR bumps all the NAPI related dependencies

Closes: #19977
Closes: #19976
Closes: #19973
Closes: #19972
Closes: #19971
Closes: #19970

Test plan

  1. All tests still pass

[ci-all] to verify on Windows and macOS as well

@RobinMalfait RobinMalfait requested a review from a team as a code owner April 26, 2026 13:58
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ac085ceb-5179-4af4-8bca-291485d626c8

📥 Commits

Reviewing files that changed from the base of the PR and between e4db31f and 31f6757.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • crates/node/package.json
✅ Files skipped from review due to trivial changes (1)
  • crates/node/package.json

Walkthrough

Updated dependency version ranges and toolchain pinning across Node and Rust components. In crates/node/npm/wasm32-wasi/package.json the following packages were bumped: @napi-rs/wasm-runtime ^1.1.1^1.1.4, @emnapi/core ^1.8.1^1.10.0, @emnapi/runtime ^1.8.1^1.10.0, and @emnapi/wasi-threads ^1.1.0^1.2.1. In crates/node/Cargo.toml Rust crate dependencies were updated: napi 3.3.03.8.5, napi-derive 3.2.53.5.4, and napi-build 2.2.32.3.1. rust-toolchain.toml channel pin changed 1.85.01.95.0. No public API or other metadata was modified.

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Linked Issues check ❓ Inconclusive PR updates all dependencies specified in linked issues: @napi-rs/wasm-runtime 1.1.1→1.1.4 [#19977], @napi-rs/cli 3.4.1→3.6.2 [#19976], emnapi/core/runtime 1.8.1→1.9.2 [#19972,#19973,#19971], @emnapi/wasi-threads 1.1.0→1.2.1 [#19970]. However, test results not provided. Verify test suite passes (especially threading, WASM memory, async workers) and CI confirms no regressions on Windows/macOS before merging.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed Title accurately and concisely describes the main change: bumping NAPI-related dependencies across multiple files.
Description check ✅ Passed Description clearly explains the PR bumps NAPI dependencies and references all six linked issues (#19977, #19976, #19973, #19972, #19971, #19970) with appropriate test plan.
Out of Scope Changes check ✅ Passed All changes are in-scope: dependency version bumps in package.json and Cargo.toml files, plus rust-toolchain.toml update to 1.95.0, all directly supporting NAPI dependency updates.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@RobinMalfait RobinMalfait merged commit 615835d into main Apr 26, 2026
23 checks passed
@RobinMalfait RobinMalfait deleted the chore/bump-napi-dependencies branch April 26, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant