Skip to content

Improve CI for NAPI-RS#19983

Merged
RobinMalfait merged 4 commits intomainfrom
feat/improve-ci
Apr 26, 2026
Merged

Improve CI for NAPI-RS#19983
RobinMalfait merged 4 commits intomainfrom
feat/improve-ci

Conversation

@RobinMalfait
Copy link
Copy Markdown
Member

@RobinMalfait RobinMalfait commented Apr 26, 2026

This PR updates the CI workflows related to NAPI-RS. So far, we've been using a custom ghcr.io based image, but these run on Node v18.

With this PR, I created a new project using napi new, with GitHub Actions workflow setup. Then essentially ported the changes from that new project to this project (as minimal as possible).

The main goal was to be able to bump NAPI-RS related dependencies and get an insiders release out. The images used in these CI jobs were blockers to get an actual (insiders) release out.

Test plan

  1. CI still passes
  2. Added a dry-run on the prepare release workflow to test that we got through the entire workflow without issues

@RobinMalfait RobinMalfait marked this pull request as ready for review April 26, 2026 17:36
@RobinMalfait RobinMalfait requested a review from a team as a code owner April 26, 2026 17:36
@RobinMalfait RobinMalfait merged commit 107e451 into main Apr 26, 2026
22 checks passed
@RobinMalfait RobinMalfait deleted the feat/improve-ci branch April 26, 2026 17:37
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 26, 2026

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

This pull request updates GitHub Actions workflows across four files. The pnpm/action-setup action is upgraded from v4 to v6 in ci.yml, integration-tests.yml, prepare-release.yml, and release.yml. The prepare-release.yml and release.yml workflows undergo significant restructuring: the Linux build matrix removes per-target Docker container usage and instead introduces per-target build-flags, expands cargo caching configuration, adds Zig tooling setup for musl targets, implements conditional stripping logic based on target architecture, and adds targeted apt package installation for aarch64. The prepare-release.yml workflow also introduces a new dry_run workflow input parameter with default value true.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Improve CI for NAPI-RS' directly relates to the main focus of the changeset, which comprehensively updates CI workflows and GitHub Actions configurations for NAPI-RS.
Description check ✅ Passed The description clearly explains the context and motivation for the CI workflow updates, including replacing custom container images and porting changes from a fresh NAPI-RS project setup.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant