Do not generate CSS for start and end#20003
Conversation
Instead of `--spacing: 1rem`. This now makes the tests fail (as expected) because `start` and `end` on their own are generated which should not have been the case.
This means that `start` and `end` on their own won't generate a value, similar to how it didn't used to do this when we moved these utilities to the legacy section.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughTests for legacy 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Review rate limit: 3/5 reviews remaining, refill in 21 minutes and 36 seconds. Comment |
This PR fixes a bug where CSS was generated for
startandend. This was accidentally introduced when we moved thestart-*andend-*utilities to the legacy utilities. But this meant that we now generate CSS forstartandendeven if no value is provided.Fixes: #20002
Test plan
--spacing: 0.25remwhich made the tests fail, and are fixed again by applying the fix.