Fix parsing bug in SelectorParser#20090
Conversation
Confidence Score: 5/5Safe to merge — the change is a one-condition guard in a well-tested parser that corrects a silent mis-parse of double-colon pseudo-elements. The fix is minimal and surgical: a single No files require special attention. Reviews (1): Last reviewed commit: "ensure `::before` gets parsed as a singl..." | Re-trigger Greptile |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThis PR adds support for parsing CSS pseudo-element selectors using double-colon syntax (e.g., 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Comment |
While working on another feature, I noticed that a selector such as
.foo::beforewas parsed as:Instead of:
So far this hasn't been a real issue in practice, but it is in a follow-up PR that I'm working on. To keep things separated, I wanted to fix this behavior in a dedicated PR instead.
Test plan