Use a finite radius for rounded-full#20126
Conversation
Confidence Score: 5/5This is a safe, minimal one-line fix with well-understood behavior; The change touches exactly one static value used by all rounded-corner utilities, the test snapshot is updated to match, and the No files require special attention. Reviews (1): Last reviewed commit: "fix: use finite radius for rounded-full" | Re-trigger Greptile |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThis PR updates the 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hey! Going to keep |
Summary
Fixes #20125.
rounded-fullcurrently emitscalc(infinity * 1px). When production optimization runs through Lightning CSS, that value is serialized as an extremely large finite pixel value, which can cause rendering issues in some engines.This switches the built-in fallback for
rounded-fullto9999px, while still allowing users to override it with--radius-fullin their theme.Test plan
pnpm exec vitest run packages/tailwindcss/src/utilities.test.ts -t roundedpnpm exec vitest run packages/tailwindcss/src/utilities.test.tspnpm exec prettier --check packages/tailwindcss/src/utilities.ts packages/tailwindcss/src/utilities.test.tsgit diff --checkpnpm build