FeatureRequest on improving exception creation #366

Ingvord · 2017-05-05T09:12:51Z

Currently developer must provide an origin of the exception in the code manually:

ApiCommExcept::re_throw_exception(one,
    (const char*)"API_CommunicationFailed",
    desc.str(),
    (const char*)"DeviceProxy::command_list_query()");// NOTE THIS LINE

We can automatize this using __func__, __LINE__ and __FILE__. See for instance this post on SO

* Close #4

Change output directory for doxygen: source -> binary

Add documentation section

install tango.h

Change install path: tango/idl -> idl

* adjust pkg-config file; link tango against dl

* add cpack

Revert tests

replace CORBA::string_dup with Tango

replace CORBA::Type with DevType

* close #275

Swapped origin and desc in some versions of Tango::Except::throw_exception.

* close #235 (SF793) API_AsynReplyNotArrived exception was wrongly thrown when asyn call response was received in the last 20ms before the call timeout expiration.

* changed permissions to make setup.sh and shutdown.sh test environment scripts executable * removed unused RcsId variable from source files

Generates files from IDL only at compilation time and only if necessary

(Crash when a client receives attribute configuration events with non empty enum labels field)

This reintroduces a small memory leak but will avoid crashes reported in the following tickets: SF814, SF823 and SF827.

(Event relative change filter does nothing) Archive relative change events were affected too. Link to Sourceforge ticket: https://sourceforge.net/p/tango-cs/bugs/825

Add tangodsdir variable to tango.pc. Defaults to CMAKE_INSTALL_FULL_BINDIR. Can be set via TANGO_DEVICE_SERVER_PATH cmake variable

Fix #313

* Fix #314: Check ZmqEventSubscriptionChange command event parameter

Give a bit more details and added a link to a page describing the GitHub workflow with fork/PR in more details.

* progress #339: pointer-cast-size-mismatch attrgetsetprop.cpp:200

Add CLion badge

Events received with UNKNOWN data format and without values when subscribing from a Tango 9 client to a Tango 7 server DevShort attribute

This reverts commit 64f2bd6.

… when the device server runs on a host with multiple network interfaces

... to track master branch build status

This bug was generating an exception when a server was trying to set an attribute property (e.g. set_max_value) when a memorized attribute was written during device init phase (write hardware at init feature).

This is the code style which looks the closest from the original Tango C++ kernel code style.

t-b · 2017-06-09T15:58:02Z

Sounds like a good idea. If we do that I would also appreciate overloads accepting std::string.

t-b · 2018-02-27T11:02:58Z

According to 1 I think using PRETTY_FUNCTION for gcc should be prefered over func as it has the namespace, class and function parameters as well. MSVC seems to not have something as good.

Unfortunately we would have to do this with a macro though.

Ingvord · 2018-02-27T11:09:25Z

Well, I was thinking about to use this library: https://github.com/boostorg/stacktrace

But as we prefer not to depend on 3rd party libraries we will have to fetch the source code and include into our code, or just copy-and-paste the main idea...

t-b · 2018-02-27T11:16:20Z

@Ingvord Nice library! But a big invasive for my taste. You could make depending on it optional. Just grabbing the source and including it is usally a bad idea.

Ingvord and others added 30 commits October 6, 2016 22:30

Progress #4 (#271)

1189c23

* Close #4

fix cmake error msg: No such file setup.sh/shutdown.sh

2397c68

Update Doxyfile.cmake

2ae1f27

Change output directory for doxygen: source -> binary

Update README.md

5a2c328

Add documentation section

Update CMakeLists.txt

cebcd9b

install tango.h

Update CMakeLists.txt

2120239

Change install path: tango/idl -> idl

Link libtango against dl (#277)

8df9e7a

* adjust pkg-config file; link tango against dl

Add cpack (#279)

690cc3b

* add cpack

improve deb control

6d01436

Update README.md

561e6af

Update README.md

d6bc2b9

Update README.md

30e8ef7

Update CMakeLists.txt

7957cd7

Revert tests

replace CORBA::string_dup with Tango

1b65156

Merge pull request #284 from Ingvord/master

640a31f

replace CORBA::string_dup with Tango

replace CORBA::Type with DevType

d8f726c

Merge pull request #286 from Ingvord/master

26bd31b

replace CORBA::Type with DevType

resolve #275 (#289)

2b3502d

* close #275

close #275

0d04a7e

fix code highlighting in CLion

fa2484a

fix code highlighting in CLion, 2

1d7900a

Fix bug #301 (SF822)

06a372d

Swapped origin and desc in some versions of Tango::Except::throw_exception.

Fix bug #235(SF793) (#306)

240f01d

* close #235 (SF793) API_AsynReplyNotArrived exception was wrongly thrown when asyn call response was received in the last 20ms before the call timeout expiration.

old_tests::polling -> cxx_old_poll

a5f30ba

Create .gitignore

9f95be7

resolve #322 - remove rcsid (#323)

c16f942

* changed permissions to make setup.sh and shutdown.sh test environment scripts executable * removed unused RcsId variable from source files

sync with #325 (#326)

64f2bd6

Generates files from IDL only at compilation time and only if necessary

Fix bug SF828

9be80d0

(Crash when a client receives attribute configuration events with non empty enum labels field)

Revert changes introduced in svn r28853

dcbc6b9

This reintroduces a small memory leak but will avoid crashes reported in the following tickets: SF814, SF823 and SF827.

Fix bug SF825

2b4643d

(Event relative change filter does nothing) Archive relative change events were affected too. Link to Sourceforge ticket: https://sourceforge.net/p/tango-cs/bugs/825

Ingvord and others added 22 commits December 15, 2016 14:30

Update tango.pc.cmake (#311)

f0e9619

Add tangodsdir variable to tango.pc. Defaults to CMAKE_INSTALL_FULL_BINDIR. Can be set via TANGO_DEVICE_SERVER_PATH cmake variable

Improve AttributeProxy documentation for subscribe_event methods

123f71d

Fix #313

Fix #312 and SF829: zmq 4.2.0 memory alignment

707f28e

add TODO

16bbdc9

Add management of unknown exception thrown by write attribute methods

2fdc64b

Fix#314 master (#336)

cea3f7b

* Fix #314: Check ZmqEventSubscriptionChange command event parameter

Update CONTRIBUTE.md

eb1a948

Give a bit more details and added a link to a page describing the GitHub workflow with fork/PR in more details.

cppTango-#339: pointer-cast-size-mismatch attrgetsetprop.cpp:200 (#340)

e324ce4

* progress #339: pointer-cast-size-mismatch attrgetsetprop.cpp:200

Update README.md

d7a4d12

Add CLion badge

Fix TangoTickets issue 3

be9e37c

Events received with UNKNOWN data format and without values when subscribing from a Tango 9 client to a Tango 7 server DevShort attribute

Improve ZmqEventSubscriptionChange command argin and argout descriptions

9fc529a

Revert "sync with #325 (#326)"

bdbef4e

This reverts commit 64f2bd6.

Always remove generated files from idl before generating new ones

3ba3364

Fixed bug related to heartbeat endpoints which could eventually occur…

834184e

… when the device server runs on a host with multiple network interfaces

Fix travis CI build status image

8b65c83

... to track master branch build status

add code style to the project

ea387e6

improve test

4c211cc

Fix bug in Attribute::get_att_device_class()

1a80b96

This bug was generating an exception when a server was trying to set an attribute property (e.g. set_max_value) when a memorized attribute was written during device init phase (write hardware at init feature).

Fix #360 aka merge PR #362

815dc07

add missing test; fix code style

a0ed651

CLion code style based on Allman Braces code style.

8bbf021

This is the code style which looks the closest from the original Tango C++ kernel code style.

empty

d239963

Ingvord added the help wanted label Jan 30, 2018

t-b force-pushed the master branch from 37abbe7 to c3d153f Compare June 12, 2020 15:01

bourtemb mentioned this pull request Jul 7, 2020

Use map for attribute lookup in MultiAttribute::check_associated #564

Merged

t-b closed this Feb 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

FeatureRequest on improving exception creation #366

FeatureRequest on improving exception creation #366

Uh oh!

Ingvord commented May 5, 2017

Uh oh!

t-b commented Jun 9, 2017

Uh oh!

t-b commented Feb 27, 2018

Uh oh!

Ingvord commented Feb 27, 2018

Uh oh!

t-b commented Feb 27, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

FeatureRequest on improving exception creation #366

FeatureRequest on improving exception creation #366

Uh oh!

Conversation

Ingvord commented May 5, 2017

Uh oh!

t-b commented Jun 9, 2017

Uh oh!

t-b commented Feb 27, 2018

Uh oh!

Ingvord commented Feb 27, 2018

Uh oh!

t-b commented Feb 27, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants