Closed
Conversation
Member
|
what do you think about logging unknown fields in the future (only on values actually specified in the config if possible)? |
Member
Author
|
The CLI validates the schema so we're not left in the dark here. Idk if it can be improved. |
Member
|
Yeah, i was thinking about what if users see new features/config options and only update the cli and wonder why the config doesn't have any effect |
Member
Author
|
I don't think there's an easy way to do that using serde. Maybe we should just improve the error message instead. |
Member
Author
|
I think I'll change the CLI to pass only the merge config instead to avoid conflicts. |
Member
Author
|
Closing in favor of #4598 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information