Update import attributes assert tests to current semantics#3919
Merged
Conversation
nicolo-ribaudo
force-pushed
the
import-attributes-2
branch
from
96c40eb to
e6c3a38
Compare
ljharb
approved these changes
Sep 12, 2023
ljharb
left a comment
ljharb
left a comment
Member
There was a problem hiding this comment.
LGTM but i'd prefer more maintainers to approve before merging
nicolo-ribaudo
commented
Sep 13, 2023
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Ms2ger
force-pushed
the
import-attributes-2
branch
from
44301f7 to
7cf6e1d
Compare
anba
added a commit
to anba/test262
that referenced
this pull request
Sep 25, 2023
- Correct file paths in "ensure-linking-error_FIXTURE.js" - Remove no longer valid assertion in "import-assertion-empty.js". See also tc39#3919.
ptomato
pushed a commit
that referenced
this pull request
Sep 25, 2023
- Correct file paths in "ensure-linking-error_FIXTURE.js" - Remove no longer valid assertion in "import-assertion-empty.js". See also #3919.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was part of #3843, but:
assertsemantics, it does not addwithtests yet (I'll do that in a follow-up)There is some complexity related to tests with invalid attributes, that should throw when linking, so I have a bunch of tests to verify valid syntax that will throw then during resolution.