Skip to content

Fix import assertions tests#3932

Merged
ptomato merged 1 commit into
tc39:mainfrom
anba:import-assertion-path
Sep 25, 2023
Merged

Fix import assertions tests#3932
ptomato merged 1 commit into
tc39:mainfrom
anba:import-assertion-path

Conversation

@anba

@anba anba commented Sep 25, 2023

Copy link
Copy Markdown
Contributor
  • Correct file paths in "ensure-linking-error_FIXTURE.js"
  • Remove no longer valid assertion in "import-assertion-empty.js".

See also #3919.

@anba
Fix import assertions tests
8f2809a 
- Correct file paths in "ensure-linking-error_FIXTURE.js"
- Remove no longer valid assertion in "import-assertion-empty.js".

See also tc39#3919.
@anba anba requested a review from a team as a code owner September 25, 2023 06:30
@nicolo-ribaudo

nicolo-ribaudo commented Sep 25, 2023

Copy link
Copy Markdown
Member

@anba Not sure if you saw it, but if you need with tests you can find them at #3921 (I will apply this patch also to that PR).

@anba

anba commented Sep 25, 2023

Copy link
Copy Markdown
Contributor Author

@anba Not sure if you saw it, but if you need with tests you can find them at #3921 (I will apply this patch also to that PR).

I don't actually work on implementing import assertions, I only noticed these test failures when updating SpiderMonkey's test262 copy. 😄

@Ms2ger Ms2ger enabled auto-merge (rebase) September 25, 2023 10:40
@ptomato

ptomato commented Sep 25, 2023

Copy link
Copy Markdown
Contributor

Unfortunately, the auto-merge won't work because of #3891.

@ptomato ptomato disabled auto-merge September 25, 2023 15:33
ptomato
ptomato approved these changes Sep 25, 2023
View reviewed changes

@ptomato ptomato left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving

@ptomato ptomato merged commit 989377d into tc39:main Sep 25, 2023
@anba anba deleted the import-assertion-path branch September 28, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ptomato ptomato ptomato approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anba @nicolo-ribaudo @ptomato