Add zero-denominator guards to SMOD, ADDMOD, MULMOD#57
Closed
tcrypt25519 with Copilot wants to merge 4 commits into
Closed
Add zero-denominator guards to SMOD, ADDMOD, MULMOD#57tcrypt25519 with Copilot wants to merge 4 commits into
tcrypt25519 with Copilot wants to merge 4 commits into
Conversation
Changed Files
|
Co-authored-by: tcrypt25519 <212655132+tcrypt25519@users.noreply.github.com>
Co-authored-by: tcrypt25519 <212655132+tcrypt25519@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add guard on zero for SMOD, ADDMOD, and MULMOD operations
Add zero-denominator guards to SMOD, ADDMOD, MULMOD
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SMOD, ADDMOD, and MULMOD were missing zero-denominator checks required by EVM spec. Per spec, these operations must return 0 when the denominator is 0.
Changes
smod(),addmod(), andmulmod()following existing DIV/MOD patternImplementation
Uses LLVM select to conditionally return zero:
This matches the pattern already used by DIV (line 381) and MOD (line 411).
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.