Delete Cert ui #88
Merged
Delete Cert ui #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename to Router or make method Handle. A Router should Route, etc.This comment was generated by todo based on a
|
Contributor
Author
|
It's not super clear but "asdf" is the common name of the cert. Usually it will say something like "farts.poo.com" but right now "asdf" is considered a real domain when it shouldn't be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Previously, no UI functionality existed for deleting certs.
Approach
Add a page for confirmation of cert delete.
Testing
Create and delete certs as you please.
Misc.
Needs help from @domshyra
