Skip to content

fix(release): stop duplicating GitHub release title - #1851

Merged
tekton-robot merged 1 commit into
tektoncd:mainfrom
jkhelil:fix-github-release-title-duplicate-name
Aug 4, 2026
Merged

fix(release): stop duplicating GitHub release title#1851
tekton-robot merged 1 commit into
tektoncd:mainfrom
jkhelil:fix-github-release-title-duplicate-name

Conversation

@jkhelil

@jkhelil jkhelil commented Aug 4, 2026

Copy link
Copy Markdown
Member

Changes

The create-draft-release task's github_release_oci.yaml pin was
still on the commit before tektoncd/plumbing#3519, so this pipeline
never picked up the upstream fix for the duplicated, quoted release
title.

This PR:

  • Bumps the pinned plumbing revision to main, which includes that
    fix.

  • Drops this pipeline's own Release ${VERSION} fallback name in
    prepare-draft-release: the plumbing task only avoids the
    duplicated title when release-name is empty, so synthesizing a
    non-empty fallback here defeated the fix, producing titles like:

    Tekton Chains release v0.28.0 "Release v0.28.0"
    
  • Wires up the new draft param (default "false") introduced by
    that same plumbing PR, so releases are published directly instead
    of being left as an unpublished draft that a maintainer has to
    manually publish.

/kind bug

Submitter Checklist

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Fix duplicated GitHub release titles and publish releases directly instead of leaving them as unpublished drafts.

Made with Cursor

The create-draft-release task's github_release_oci.yaml pin was
still on the commit before tektoncd/plumbing#3519, so this pipeline
never picked up the upstream fix for the duplicated, quoted release
title.

Bump the pinned plumbing revision to main, which includes that fix,
and drop this pipeline's own "Release ${VERSION}" fallback name in
prepare-draft-release: the plumbing task only avoids the duplicated
title when release-name is empty, so synthesizing a non-empty
fallback here defeated the fix, producing titles like:

  Tekton Chains release v0.28.0 "Release v0.28.0"

Also wire up the new "draft" param (default "false") introduced by
that same plumbing PR, so releases are published directly instead of
being left as an unpublished draft that a maintainer has to manually
publish.

Signed-off-by: Jawed khelil <jkhelil@redhat.com>
Assisted-by: Claude Sonnet 5 (via Cursor)
Co-authored-by: Cursor <cursoragent@cursor.com>
@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 4, 2026
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 4, 2026
@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.90%. Comparing base (cb6a244) to head (0335906).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1851      +/-   ##
==========================================
- Coverage   61.95%   61.90%   -0.05%     
==========================================
  Files          64       64              
  Lines        4071     4071              
==========================================
- Hits         2522     2520       -2     
- Misses       1268     1269       +1     
- Partials      281      282       +1     
Flag Coverage Δ
unit-tests 61.90% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jkhelil

jkhelil commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

/retest

Comment thread .tekton/release-patch.yaml

@infernus01 infernus01 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2026
@tekton-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: infernus01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2026
@tekton-robot
tekton-robot merged commit 01d9ebf into tektoncd:main Aug 4, 2026
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants