[cherry-pick: release-v0.27.x] fix(release): stop duplicating GitHub release title - #1853
Open
jkhelil wants to merge 1 commit into
Open
[cherry-pick: release-v0.27.x] fix(release): stop duplicating GitHub release title#1853jkhelil wants to merge 1 commit into
jkhelil wants to merge 1 commit into
Conversation
The create-draft-release task's github_release_oci.yaml pin was still on the commit before tektoncd/plumbing#3519, so this pipeline never picked up the upstream fix for the duplicated, quoted release title. Bump the pinned plumbing revision to main, which includes that fix, and drop this pipeline's own "Release ${VERSION}" fallback name in prepare-draft-release: the plumbing task only avoids the duplicated title when release-name is empty, so synthesizing a non-empty fallback here defeated the fix, producing titles like: Tekton Chains release v0.28.0 "Release v0.28.0" Also wire up the new "draft" param (default "false") introduced by that same plumbing PR, so releases are published directly instead of being left as an unpublished draft that a maintainer has to manually publish. Signed-off-by: Jawed khelil <jkhelil@redhat.com> Assisted-by: Claude Sonnet 5 (via Cursor) Co-authored-by: Cursor <cursoragent@cursor.com> (cherry picked from commit 0335906)
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
tekton-robot
added
the
size/S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #1851
/kind bug
Changes
The
create-draft-releasetask'sgithub_release_oci.yamlpin wasstill on the commit before tektoncd/plumbing#3519, so this pipeline
never picked up the upstream fix for the duplicated, quoted release
title.
This PR:
Bumps the pinned plumbing revision to
main, which includes thatfix.
Drops this pipeline's own
Release ${VERSION}fallback name inprepare-draft-release: the plumbing task only avoids theduplicated title when
release-nameis empty, so synthesizing anon-empty fallback here defeated the fix, producing titles like:
Wires up the new
draftparam (default"false") introduced bythat same plumbing PR, so releases are published directly instead
of being left as an unpublished draft that a maintainer has to
manually publish.
Submitter Checklist
functionality, content, code)
Release Notes
Made with Cursor