Merge upstream temporalio/temporal (124 commits, up to df2e384da)#20
Merged
Merge upstream temporalio/temporal (124 commits, up to df2e384da)#20
Conversation
…not found (temporalio#9407) ## What changed? - Fixed an issue caused while refactoring in temporalio#9290 where the not found error was translated to a non retryable error. - Use non retryable nexus handler errors instead of directly setting the `nexus-request-retryable` header directly. It is set for backward compatibility only. - Added relevant tests. ## Why? Fix a regression
## What changed? - Remove Docker Builds submodule update - update instructions on updating the go version ## Why? docker-builds is no longer used to build server docker images for new releases
## What changed? Exclude Query in health probe data ## Why? Query workflow could be high latency is there is no user worker. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
## What changed? Fix legacy query converter search attribute precedence. ## Why? For conflicting search attribute aliases, custom search attributes should take precedence, then chasm, then system/predefined search attributes. Legacy converter incorrectly resolves system search attribute before chasm. ## How did you test it? - [X] built - [X] run locally and tested manually - [X] covered by existing tests - [X] added new unit test(s) - [X] added new functional test(s)
…temporalio#9420) ## Why I wondered if this works as expected and ended up adding this test. Figured I might as well commit it.
## What changed? WISOTT ## Why? TestEnv allows running tests in parallel; speeding up local execution of the suite. TBD ## How did you test it? - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
## What changed? Add a new cli tool to run the matching fairness simulator, and some tests for basic fairness behavior. ## Why? So users can tell how it will behave for their workloads.
…emporalio#9329) ## What changed? Fixed a bug in the gcloud visibility_archiver.go file and added a new unit test in visibility_archiver_test.go. ## Why? There is a bug in the visibility-archiver implementation of the Google Cloud archiver. All archived workflows are being retrieved and displayed twice. This change fixes that bug. ## How did you test it? - [X] built - [X] run locally and tested manually - [ ] covered by existing tests - [X] added new unit test(s) - [ ] added new functional test(s) ## Potential risks No risk since the archiver is completely decoupled from the core functionality.
## What changed? Add `fairsim` binary (from temporalio#8158) to `.gitignore` and `make clean` and remove it from the repo. (Don't add it to `make bins` since it's not generally useful.) ## Why It accidentally got checked in.
## What changed? Activity tasks delivered to workers through the eager activity execution feature were missing the `Priority` property. This caused the `Priority` property to be missing on the [SDK side](https://github.com/temporalio/sdk-dotnet/blob/main/src/Temporalio/Activities/ActivityInfo.cs#L60) when activities were eagerly dispatched to workers, which was a difference in behavior from non-eager activities. ## Why? Users expect a consistent experience in terms of what metadata is available inside of an activity ## How did you test it? - [X] built - [X] run locally and tested manually - [x] covered by existing tests - [X] added new unit test(s) - [x] added new functional test(s) There did not appear to be any tests in workflow_task_completed_handler_test.go for eager activity execution, but I could add some if needed. I started the server via `make start` and verified that the SDK is now receiving priority when activities are eagerly dispatched. Before running the command, I modified the `config/dynamicconfig/development-sql.yaml` file like below to enable the feature: ```yaml system.enableActivityEagerExecution: - value: true ``` I compared with Temporal CLI 1.6.1 `temporal server start-dev --dynamic-config-value system.enableActivityEagerExecution=true`, where the SDK is not receiving priority for these activities. ## Potential risks I believe this is relatively low risk because `Priority` does not drive any decisions on the SDK side
## What changed? Fix issues with flakereport; see comments for details. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) <details><summary>Example</summary> <p> ## Flaky Tests Report - 2026-02-25 11:25:50 ### Overall Statistics * **CI Success Rate**: 4/8 (50.00%) * **Total Test Runs**: 261830 * **Total Failures**: 404 * **Overall Failure Rate**: 1.5 per 1000 tests ### Failure Categories Summary | Category | Unique Tests | |----------|--------------| | CI Breakers | 1 | | Crashes | 1 | | Timeouts | 0 | | Flaky Tests | 129 | ### CI Breakers (Failed All Retries) | Test | CI Runs Broken | Total Failures | Last Failure | Links | |------|---------------|----------------|-------------|-------| | `TestVersionWorkflowSuite/v2/Test_DeleteVersion_QueryAfterDeletion` | 1 | 1 | 21h ago | [1](https://github.com/temporalio/temporal/actions/runs/22373551837/job/1) | ### Crashes | Test | Flake Rate | Last Failure | Links | |------|------------|-------------|-------| | `unit-test` | **100.0% (2/2)** | 21h ago | [1](https://github.com/temporalio/temporal/actions/runs/22373551837/job/1) [2](https://github.com/temporalio/temporal/actions/runs/22296780641/job/1) | ### Flaky Tests | Test | Flake Rate | Last Failure | Links | |------|------------|-------------|-------| | `TestClientDataConverterTestSuite` | **100.0% (1/1)** | 44h ago | [1](https://github.com/temporalio/temporal/actions/runs/22329840058/job/64609560060) | | `PANIC: runtime error: index out of range [0] with length 0 [recovered, repanicked] — in go.temporal.io/server/tests.TestWorkflowUpdateSuite.func21.2` | **100.0% (1/1)** | 44h ago | [1](https://github.com/temporalio/temporal/actions/runs/22329840058/job/64609560060) | | `PANIC: Fail in goroutine after TestVersioning3FunctionalSuiteV2/TestWorkflowWithPinnedOverride_NoSticky has completed — in TestVersioning3FunctionalSuiteV0/TestActivityRetryAutoUpgradeDuringBackoff` | **100.0% (1/1)** | 44h ago | [1](https://github.com/temporalio/temporal/actions/runs/22329840058/job/64609560075) | | `PANIC: Fail in goroutine after TestVersioning3FunctionalSuiteV0/TestPinnedQuery_RollbackDrainedVersion/ForceTaskForwardNoPollForwardForceAsync has completed — in TestVersioning3FunctionalSuiteV2/TestActivityRetryAutoUpgradeDuringBackoff` | **100.0% (1/1)** | 60h ago | [1](https://github.com/temporalio/temporal/actions/runs/22296780641/job/64495114191) | | `DATA RACE: Data race detected` | **100.0% (1/1)** | 23h ago | [1](https://github.com/temporalio/temporal/actions/runs/22367698230/job/64738198239) | | `PANIC: runtime error: invalid memory address or nil pointer dereference — in go.temporal.io/server/tests.(*DeploymentVersionSuite).TestForceCAN_WithOverrideState.func1` | **100.0% (1/1)** | 38h ago | [1](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068496) | | `TestVersioning3FunctionalSuiteV0/TestTransitionDuringTransientTask_WithSignal` | **48.9% (45/92)** | 1h ago | [1](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456075) [2](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456229) [3](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456270) | | `TestVersioning3FunctionalSuiteV2/TestTransitionDuringTransientTask_WithoutSignal` | **48.9% (45/92)** | 1h ago | [1](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456093) [2](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456143) [3](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456167) | | `TestVersioning3FunctionalSuiteV2/TestTransitionDuringTransientTask_WithSignal` | **48.9% (45/92)** | 1h ago | [1](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456136) [2](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456111) [3](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456112) | | `TestVersioning3FunctionalSuiteV0/TestTransitionDuringTransientTask_WithoutSignal` | **43.4% (36/83)** | 1h ago | [1](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456143) [2](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456236) [3](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456250) | | `TestVersionWorkflowSuite/v2/Test_DeleteVersion_QueryAfterDeletion` | **42.9% (3/7)** | 21h ago | [1](https://github.com/temporalio/temporal/actions/runs/22373551837/job/1) [2](https://github.com/temporalio/temporal/actions/runs/22373551837/job/1) [3](https://github.com/temporalio/temporal/actions/runs/22373551837/job/1) | | `TestUserData_FetchesUpTree` | **16.7% (1/6)** | 23h ago | [1](https://github.com/temporalio/temporal/actions/runs/22367698230/job/1) | | `TestNewServerWithOTEL/with_OTEL_Collector_running` | **16.7% (1/6)** | 21h ago | [1](https://github.com/temporalio/temporal/actions/runs/22373551837/job/1) | | `TestInterleavedWeightedRoundRobinSchedulerSuite/TestInactiveChannelDeletionRace` | **16.7% (1/6)** | 60h ago | [1](https://github.com/temporalio/temporal/actions/runs/22296780641/job/1) | | `TestUserData_FetchesActivityToWorkflow` | **16.7% (1/6)** | 23h ago | [1](https://github.com/temporalio/temporal/actions/runs/22367698230/job/1) | | `TestDeploymentVersionSuiteV0/TestReactivationSignalCache_Deduplication_StartWorkflow` | **16.1% (9/56)** | 1h ago | [1](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456136) [2](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456111) [3](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068532) | | `TestNewServer` | **15.4% (2/13)** | 23h ago | [1](https://github.com/temporalio/temporal/actions/runs/22367698230/job/1) [2](https://github.com/temporalio/temporal/actions/runs/22367698230/job/1) | | `TestDeploymentVersionSuiteV0/TestReactivationSignalCache_Deduplication_SignalWithStart` | **11.3% (6/53)** | 21h ago | [1](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512764) [2](https://github.com/temporalio/temporal/actions/runs/22367698230/job/64738198239) [3](https://github.com/temporalio/temporal/actions/runs/22367698230/job/64738198192) | | `TestDeploymentVersionSuiteV0/TestStartWorkflowExecution_ReactivateVersionOnPinned_WithConflictPolicy` | **9.6% (5/52)** | 21h ago | [1](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512848) [2](https://github.com/temporalio/temporal/actions/runs/22367698230/job/64738198189) [3](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068462) | | `TestDeploymentVersionSuiteV2/TestVersionScavenger_DeleteOnAdd` | **9.6% (5/52)** | 1h ago | [1](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456111) [2](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512818) [3](https://github.com/temporalio/temporal/actions/runs/22367698230/job/64738198207) | | `TestDeploymentVersionSuiteV0/TestStartWorkflowExecution_ReactivateVersionOnPinned` | **9.3% (5/54)** | 21h ago | [1](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512766) [2](https://github.com/temporalio/temporal/actions/runs/22367698230/job/64738198202) [3](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068483) | | `TestDeploymentVersionSuiteV0/TestSignalWithStartWorkflowExecution_ReactivateVersionOnPinned` | **7.8% (4/51)** | 21h ago | [1](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512865) [2](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512840) [3](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512870) | | `TestFairnessAutoEnableSuite/Test_Activity_Basic` | **7.7% (4/52)** | 1h ago | [1](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456112) [2](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512799) [3](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068532) | | `TestDeploymentVersionSuiteV2/TestReactivationSignalCache_Deduplication_UpdateOptions` | **7.7% (4/52)** | 21h ago | [1](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512837) [2](https://github.com/temporalio/temporal/actions/runs/22329840058/job/64609560075) [3](https://github.com/temporalio/temporal/actions/runs/22296780641/job/64495114191) | | `TestActivityClientTestSuite/TestActivityScheduleToClose_FiredDuringBackoff` | **7.5% (4/53)** | 1h ago | [1](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456152) [2](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512837) [3](https://github.com/temporalio/temporal/actions/runs/22367698230/job/64738198228) | | `TestDeploymentVersionSuiteV0/TestReactivationSignalCache_Deduplication_Reset` | **6.0% (3/50)** | 38h ago | [1](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068487) [2](https://github.com/temporalio/temporal/actions/runs/22329840058/job/64609560087) [3](https://github.com/temporalio/temporal/actions/runs/22296780641/job/64495114101) | | `TestDeploymentVersionSuiteV0/TestResetWorkflowExecution_ReactivateVersionOnPinned` | **6.0% (3/50)** | 21h ago | [1](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512828) [2](https://github.com/temporalio/temporal/actions/runs/22367698230/job/64738198239) [3](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068520) | | `TestDeploymentVersionSuiteV2/TestVersionMissingTaskQueues_ValidSetRampingVersion` | **6.0% (3/50)** | 21h ago | [1](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512818) [2](https://github.com/temporalio/temporal/actions/runs/22367698230/job/64738198207) [3](https://github.com/temporalio/temporal/actions/runs/22296780641/job/64495114123) | | `TestTaskQueueStats_Pri_Suite/TestRampingAndCurrentAbsorbUnversionedBacklog/ForceTaskForwardForcePollForwardAllowSync` | **5.9% (3/51)** | 21h ago | [1](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512818) [2](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068532) [3](https://github.com/temporalio/temporal/actions/runs/22296780641/job/64495114123) | | `TestWorkerDeploymentSuiteV0/TestSetCurrentVersion_Concurrent_DifferentVersions_NoUnexpectedErrors` | **5.9% (3/51)** | 21h ago | [1](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512837) [2](https://github.com/temporalio/temporal/actions/runs/22367698230/job/64738198193) [3](https://github.com/temporalio/temporal/actions/runs/22329840058/job/64609560075) | | `TestDeploymentVersionSuiteV0/TestUpdateWorkflowExecutionOptions_ReactivateVersionOnPinned` | **5.9% (3/51)** | 1h ago | [1](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456393) [2](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512824) [3](https://github.com/temporalio/temporal/actions/runs/22329840058/job/64609560075) | | `TestCronTestClientSuite/TestCronWorkflowCompletionStates` | **5.8% (3/52)** | 21h ago | [1](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512824) [2](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512861) [3](https://github.com/temporalio/temporal/actions/runs/22296780641/job/64495114191) | | `TestCallbacksSuiteCHASM/TestWorkflowNexusCallbacks_CarriedOver/ContinueAsNew` | **5.8% (3/52)** | 1h ago | [1](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456103) [2](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068523) [3](https://github.com/temporalio/temporal/actions/runs/22329840058/job/64609560075) | | `TestStandaloneActivityTestSuite/TestHeartbeat/HeartbeatKeepsActivityAlive` | **5.8% (3/52)** | 21h ago | [1](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512824) [2](https://github.com/temporalio/temporal/actions/runs/22367698230/job/64738198210) [3](https://github.com/temporalio/temporal/actions/runs/22367698230/job/64738198202) | | `TestCallbacksSuiteCHASM/TestWorkflowNexusCallbacks_CarriedOver/WorkflowRunTimeout` | **5.8% (3/52)** | 1h ago | [1](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456103) [2](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068523) [3](https://github.com/temporalio/temporal/actions/runs/22329840058/job/64609560075) | | `TestWorkerDeploymentSuiteV0/TestDescribeWorkerDeployment_SetCurrentVersion` | **5.8% (3/52)** | 21h ago | [1](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512837) [2](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512837) [3](https://github.com/temporalio/temporal/actions/runs/22367698230/job/64738198228) | | `TestDeploymentVersionSuiteV0/TestReactivationSignalCache_Deduplication_UpdateOptions` | 4.1% (2/49) | 1h ago | [1](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456093) [2](https://github.com/temporalio/temporal/actions/runs/22329840058/job/64609560043) | | `TestTaskQueueStats_Classic_Suite/TestAddMultipleTasks_ValidateStats_Cached` | 4.0% (2/50) | 21h ago | [1](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512837) [2](https://github.com/temporalio/temporal/actions/runs/22329840058/job/64609560075) | | `TestTaskQueueStats_Pri_Suite/TestInactiveVersionDoesNotAbsorbUnversionedBacklog/NoTaskForwardNoPollForwardAllowSync` | 4.0% (2/50) | 1h ago | [1](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456111) [2](https://github.com/temporalio/temporal/actions/runs/22367698230/job/64738198189) | | `TestTaskQueueStats_Pri_Suite/TestMultipleTasks_WithMatchingBehavior_ValidateStats/ForceTaskForwardForcePollForwardAllowSync` | 4.0% (2/50) | 21h ago | [1](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512821) [2](https://github.com/temporalio/temporal/actions/runs/22296780641/job/64495114191) | | `TestWorkerDeploymentSuiteV0/TestSetRampingVersion_AfterDrained` | 4.0% (2/50) | 38h ago | [1](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068420) [2](https://github.com/temporalio/temporal/actions/runs/22329840058/job/64609560075) | | `TestWorkerDeploymentSuiteV2/TestDrainRollbackedVersion` | 4.0% (2/50) | 38h ago | [1](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068525) [2](https://github.com/temporalio/temporal/actions/runs/22329840058/job/64609560075) | | `TestFuncClustersTestSuite/EnableTransitionHistory/TestForceMigration_ResetWorkflow` | 4.0% (2/50) | 1h ago | [1](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456146) [2](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068440) | | `TestDeploymentVersionSuiteV0/TestVersionScavenger_DeleteOnAdd` | 4.0% (2/50) | 38h ago | [1](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068551) [2](https://github.com/temporalio/temporal/actions/runs/22329840058/job/64609560075) | | `TestWorkerDeploymentSuiteV2/TestSetCurrentVersion_Concurrent_DifferentVersions_NoUnexpectedErrors` | 4.0% (2/50) | 21h ago | [1](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512837) [2](https://github.com/temporalio/temporal/actions/runs/22329840058/job/64609560090) | | `TestPrioritySuite/TestSubqueue_Migration` | 3.9% (2/51) | 21h ago | [1](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512837) [2](https://github.com/temporalio/temporal/actions/runs/22296780641/job/64495114191) | | `TestCallbacksSuiteCHASM/TestWorkflowNexusCallbacks_CarriedOver/WorkflowFailureRetry` | 3.9% (2/51) | 1h ago | [1](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456152) [2](https://github.com/temporalio/temporal/actions/runs/22329840058/job/64609560001) | | `TestWorkerDeploymentSuiteV0/TestDrainRollbackedVersion` | 3.9% (2/51) | 23h ago | [1](https://github.com/temporalio/temporal/actions/runs/22367698230/job/64738198228) [2](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068512) | | `TestVersioning3FunctionalSuiteV0/TestPinnedTask_NoProperPoller/NoTaskForwardNoPollForwardForceAsync` | 2.1% (1/48) | 38h ago | [1](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068483) | | `TestVersioning3FunctionalSuiteV2/TestPinnedCaN_UpgradeOnCaN_NormalWFT_WithSuggest/ForceTaskForwardNoPollForwardForceAsync` | 2.1% (1/48) | 60h ago | [1](https://github.com/temporalio/temporal/actions/runs/22296780641/job/64495114123) | | `TestDeploymentVersionSuiteV0/TestUpdateWorkflowExecutionOptions_SetImpliedPinnedSuccess` | 2.1% (1/48) | 21h ago | [1](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512818) | | `TestGetHistoryFunctionalSuite/DisableTransitionHistory/TestGetWorkflowExecutionHistory_All` | 2.1% (1/48) | 23h ago | [1](https://github.com/temporalio/temporal/actions/runs/22367698230/job/64738198239) | | `TestVersioning3FunctionalSuiteV2/TestUnpinnedCaN` | 2.1% (1/48) | 23h ago | [1](https://github.com/temporalio/temporal/actions/runs/22367698230/job/64738198239) | | `TestVersioningFunctionalSuite/TestWorkflowTaskRedirectInRetryNonFirstTask/NoTaskForwardForcePollForwardAllowSync` | 2.1% (1/48) | 1h ago | [1](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456112) | | `TestWorkerDeploymentSuiteV0/TestListWorkerDeployments_TwoVersions_SameDeployment_OneCurrent_OneRamping` | 2.1% (1/48) | 23h ago | [1](https://github.com/temporalio/temporal/actions/runs/22367698230/job/64738198239) | | `TestTaskQueueStats_Classic_Suite/TestMultipleTasks_WithMatchingBehavior_ValidateStats/ForceTaskForwardNoPollForwardForceAsync` | 2.1% (1/48) | 1h ago | [1](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456212) | | `TestVersioning3FunctionalSuiteV2/TestWorkflowWithPinnedOverride_NoSticky/ForceTaskForwardForcePollForwardForceAsync` | 2.1% (1/48) | 44h ago | [1](https://github.com/temporalio/temporal/actions/runs/22329840058/job/64609560075) | | `TestAdvancedVisibilitySuiteLegacy/TestListWorkflow_StringQuery` | 2.1% (1/48) | 23h ago | [1](https://github.com/temporalio/temporal/actions/runs/22367698230/job/64738198239) | | `TestVersioning3FunctionalSuiteV0/TestChildWorkflowInheritance_ParentPinnedByOverride` | 2.1% (1/48) | 23h ago | [1](https://github.com/temporalio/temporal/actions/runs/22367698230/job/64738198284) | | `TestStandaloneActivityTestSuite/TestRequestCancel/MismatchedTokenComponentRef` | 2.1% (1/48) | 1h ago | [1](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456111) | | `TestDeploymentVersionSuiteV2/TestVersionMissingTaskQueues_ValidSetCurrentVersion` | 2.1% (1/48) | 21h ago | [1](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512837) | | `TestVersioning3FunctionalSuiteV0/TestPinnedQuery_DrainedVersion_PollersAbsent/ForceTaskForwardNoPollForwardAllowSync` | 2.1% (1/48) | 23h ago | [1](https://github.com/temporalio/temporal/actions/runs/22367698230/job/64738198239) | | `TestVersioning3FunctionalSuiteV0/TestPinnedWorkflowWithLateActivityPoller/ForceTaskForwardNoPollForwardAllowSync` | 2.1% (1/48) | 60h ago | [1](https://github.com/temporalio/temporal/actions/runs/22296780641/job/64495114104) | | `TestTaskQueueStats_Classic_Suite/TestMultipleTasks_WithMatchingBehavior_ValidateStats/ForceTaskForwardForcePollForwardAllowSync` | 2.1% (1/48) | 21h ago | [1](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512839) | | `TestDeploymentVersionSuiteV2/TestStartWorkflowExecution_ReactivateVersionOnPinned_WithConflictPolicy` | 2.1% (1/48) | 1h ago | [1](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456111) | | `TestDeploymentVersionSuiteV2/TestSignalWithStartWorkflowExecution_ReactivateVersionOnPinned` | 2.1% (1/48) | 23h ago | [1](https://github.com/temporalio/temporal/actions/runs/22367698230/job/64738198239) | | `TestVersioningFunctionalSuite/TestDispatchQueryOld/ForceTaskForwardNoPollForwardAllowSync` | 2.1% (1/48) | 23h ago | [1](https://github.com/temporalio/temporal/actions/runs/22367698230/job/64738198239) | | `TestVersioningFunctionalSuite/TestWorkflowTaskRedirectInRetryFirstTask/ForceTaskForwardForcePollForwardForceAsync` | 2.1% (1/48) | 44h ago | [1](https://github.com/temporalio/temporal/actions/runs/22329840058/job/64609560075) | | `TestTaskQueueStats_Pri_Suite/TestMultipleTasks_WithMatchingBehavior_ValidateStats/ForceTaskForwardForcePollForwardForceAsync` | 2.1% (1/48) | 38h ago | [1](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068525) | | `TestWorkerDeploymentSuiteV0/TestDescribeWorkerDeployment_MultipleVersions_Sorted` | 2.0% (1/49) | 38h ago | [1](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068496) | | `TestDeploymentVersionSuiteV2/TestDrainageStatus_SetCurrentVersion_YesOpenWFs` | 2.0% (1/49) | 38h ago | [1](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068496) | | `TestVersioning3FunctionalSuiteV0/TestAutoUpgradeCaN_UpgradeOnCaN/ForceTaskForwardNoPollForwardAllowSync` | 2.0% (1/49) | 38h ago | [1](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068496) | | `TestWorkerDeploymentSuiteV2/TestSetCurrentVersion_Batching` | 2.0% (1/49) | 38h ago | [1](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068420) | | `TestTaskQueueStats_Classic_Suite/TestCurrentAbsorbsUnversionedBacklog_WhenRampingToUnversioned/NoTaskForwardForcePollForwardForceAsync` | 2.0% (1/49) | 44h ago | [1](https://github.com/temporalio/temporal/actions/runs/22329840058/job/64609560082) | | `TestTaskQueueSuite/TestTaskQueueRateLimit_UpdateFromWorkerConfigAndAPI` | 2.0% (1/49) | 1h ago | [1](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456111) | | `TestVersioning3FunctionalSuiteV0/TestPinnedQuery_RollbackDrainedVersion/ForceTaskForwardNoPollForwardForceAsync` | 2.0% (1/49) | 60h ago | [1](https://github.com/temporalio/temporal/actions/runs/22296780641/job/64495114191) | | `TestWorkflowUpdateSuite/StickySpeculativeWorkflowTask_AcceptComplete_StickyWorkerUnavailable` | 2.0% (1/49) | 44h ago | [1](https://github.com/temporalio/temporal/actions/runs/22329840058/job/64609560060) | | `TestWorkerDeploymentSuiteV2/TestResourceExhaustedErrors_Converted_To_ReadableMessage` | 2.0% (1/49) | 60h ago | [1](https://github.com/temporalio/temporal/actions/runs/22296780641/job/64495114116) | | `TestVersioning3FunctionalSuiteV0/TestPinnedCaN_UpgradeOnCaN_TransientWFT_WithSuggest/ForceTaskForwardForcePollForwardForceAsync` | 2.0% (1/49) | 1h ago | [1](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456152) | | `TestVersioning3FunctionalSuiteV2/TestPinnedCaN_UpgradeOnCaN_NormalWFT_PinnedOverride_WithSuggest/NoTaskForwardForcePollForwardAllowSync` | 2.0% (1/49) | 38h ago | [1](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068496) | | `TestTaskQueueStats_Pri_Suite/TestMultipleTasks_WithMatchingBehavior_ValidateStats/ForceTaskForwardNoPollForwardForceAsync` | 2.0% (1/49) | 44h ago | [1](https://github.com/temporalio/temporal/actions/runs/22329840058/job/64609560075) | | `TestChildWorkflowSuite/TestCronChildWorkflowExecution` | 2.0% (1/49) | 60h ago | [1](https://github.com/temporalio/temporal/actions/runs/22296780641/job/64495114114) | | `TestNexusStateReplicationTestSuite/DisableTransitionHistory/TestNexusCallbackReplicated` | 2.0% (1/49) | 1h ago | [1](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456192) | | `TestWorkerDeploymentSuiteV0/TestSetWorkerDeploymentRampingVersion_WithCurrent_Unset_Ramp` | 2.0% (1/49) | 60h ago | [1](https://github.com/temporalio/temporal/actions/runs/22296780641/job/64495114191) | | `TestFuncClustersTestSuite/EnableTransitionHistory/TestForceMigration_ClosedWorkflow` | 2.0% (1/49) | 23h ago | [1](https://github.com/temporalio/temporal/actions/runs/22367698230/job/64738198205) | | `TestTaskQueueStats_Classic_Suite/TestCurrentVersionAbsorbsUnversionedBacklog_NoRamping/ForceTaskForwardNoPollForwardForceAsync` | 2.0% (1/49) | 60h ago | [1](https://github.com/temporalio/temporal/actions/runs/22296780641/job/64495114074) | | `TestWorkflowUpdateSuite/SpeculativeWorkflowTask_ScheduleToStartTimeoutOnNormalTaskQueue` | 2.0% (1/49) | 44h ago | [1](https://github.com/temporalio/temporal/actions/runs/22329840058/job/64609560060) | | `TestStandaloneActivityTestSuite/TestRequestCancel/StaleAttemptToken` | 2.0% (1/49) | 38h ago | [1](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068496) | | `TestTaskQueueStats_Classic_Suite/TestCurrentVersionAbsorbsUnversionedBacklog_NoRamping/NoTaskForwardForcePollForwardAllowSync` | 2.0% (1/49) | 23h ago | [1](https://github.com/temporalio/temporal/actions/runs/22367698230/job/64738198284) | | `TestVersioning3FunctionalSuiteV2/TestUnpinnedQuery_NoSticky/ForceTaskForwardForcePollForwardForceAsync` | 2.0% (1/49) | 21h ago | [1](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512861) | | `TestTaskQueueStats_Classic_Suite/TestRampingAbsorbsUnversionedBacklog_WhenCurrentIsUnversioned/NoTaskForwardForcePollForwardForceAsync` | 2.0% (1/49) | 60h ago | [1](https://github.com/temporalio/temporal/actions/runs/22296780641/job/64495114191) | | `TestTaskQueueStats_Pri_Suite/TestCurrentVersionAbsorbsUnversionedBacklog_NoRamping/NoTaskForwardNoPollForwardAllowSync` | 2.0% (1/49) | 1h ago | [1](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456212) | | `TestTaskQueueStats_Pri_Suite/TestRampingAndCurrentAbsorbUnversionedBacklog/NoTaskForwardNoPollForwardAllowSync` | 2.0% (1/49) | 44h ago | [1](https://github.com/temporalio/temporal/actions/runs/22329840058/job/64609560089) | | `TestFuncClustersTestSuite/DisableTransitionHistory/TestForceMigration_ClosedWorkflow` | 2.0% (1/49) | 60h ago | [1](https://github.com/temporalio/temporal/actions/runs/22296780641/job/64495114115) | | `TestWorkerDeploymentSuiteV0/TestSetRampingVersion_Concurrent_DifferentVersions_NoUnexpectedErrors` | 2.0% (1/49) | 21h ago | [1](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512837) | | `TestTaskQueueStats_Classic_Suite/TestMultipleTasks_WithMatchingBehavior_ValidateStats/NoTaskForwardNoPollForwardAllowSync` | 2.0% (1/49) | 38h ago | [1](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068496) | | `TestVersioning3FunctionalSuiteV0/TestPinnedQuery_RollbackDrainedVersion/NoTaskForwardForcePollForwardAllowSync` | 2.0% (1/49) | 60h ago | [1](https://github.com/temporalio/temporal/actions/runs/22296780641/job/64495114191) | | `TestVersioning3FunctionalSuiteV2/TestUnpinnedQuery_NoSticky/NoTaskForwardForcePollForwardAllowSync` | 2.0% (1/49) | 38h ago | [1](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068523) | | `TestDeploymentVersionSuiteV0/TestForceCAN_WithOverrideState` | 2.0% (1/49) | 38h ago | [1](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068496) | | `TestVersioningFunctionalSuite/TestDispatchActivityFailCrossTq/NoTaskForwardForcePollForwardAllowSync` | 2.0% (1/49) | 38h ago | [1](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068496) | | `TestVersioning3FunctionalSuiteV0/TestPinnedCaN_UpgradeOnCaN_TransientWFT_WithSuggest/ForceTaskForwardNoPollForwardForceAsync` | 2.0% (1/49) | 44h ago | [1](https://github.com/temporalio/temporal/actions/runs/22329840058/job/64609560075) | | `TestWorkerDeploymentSuiteV0/TestSetWorkerDeploymentRampingVersion_Batching` | 2.0% (1/49) | 60h ago | [1](https://github.com/temporalio/temporal/actions/runs/22296780641/job/64495114191) | | `TestDeploymentVersionSuiteV0/TestDrainageStatus_SetCurrentVersion_NoOpenWFs` | 2.0% (1/50) | 38h ago | [1](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068523) | | `TestScheduleFunctionalSuite/TestNextTimeCache` | 2.0% (1/50) | 21h ago | [1](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512837) | | `TestVersioning3FunctionalSuiteV2/TestUnpinnedQuery_NoSticky/ForceTaskForwardNoPollForwardAllowSync` | 2.0% (1/50) | 60h ago | [1](https://github.com/temporalio/temporal/actions/runs/22296780641/job/64495114191) | | `TestPollerScalingFunctionalSuite/TestPollerScalingDecisionsAreSeenProbabilistically` | 2.0% (1/50) | 44h ago | [1](https://github.com/temporalio/temporal/actions/runs/22329840058/job/64609560075) | | `TestFairnessSuite/TestMigration_FromFair` | 2.0% (1/50) | 60h ago | [1](https://github.com/temporalio/temporal/actions/runs/22296780641/job/64495114116) | | `TestFairnessAutoEnableSuite/TestMigration_FromClassic` | 2.0% (1/50) | 44h ago | [1](https://github.com/temporalio/temporal/actions/runs/22329840058/job/64609560075) | | `TestTaskQueueStats_Pri_Suite/TestMultipleTasks_WithMatchingBehavior_ValidateStats/ForceTaskForwardNoPollForwardAllowSync` | 2.0% (1/50) | 23h ago | [1](https://github.com/temporalio/temporal/actions/runs/22367698230/job/64738198193) | | `TestWorkflowTaskTestSuite/TestWorkflowTaskHeartbeatingWithEmptyResult` | 2.0% (1/50) | 60h ago | [1](https://github.com/temporalio/temporal/actions/runs/22296780641/job/64495114142) | | `TestAdvancedVisibilitySuite/TestWorkerTaskReachability_Unversioned_InTaskQueue` | 2.0% (1/50) | 60h ago | [1](https://github.com/temporalio/temporal/actions/runs/22296780641/job/64495114191) | | `TestDeploymentVersionSuiteV2/TestDeleteVersion_DeleteRampedVersion` | 2.0% (1/50) | 1h ago | [1](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456152) | | `TestWorkerDeploymentSuiteV0/TestDeploymentVersionLimits` | 2.0% (1/50) | 60h ago | [1](https://github.com/temporalio/temporal/actions/runs/22296780641/job/64495114116) | | `TestVersioning3FunctionalSuiteV2/TestPinnedQuery_RollbackDrainedVersion/ForceTaskForwardForcePollForwardForceAsync` | 2.0% (1/50) | 1h ago | [1](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456152) | | `TestVersioning3FunctionalSuiteV2/TestUnpinnedQuery_NoSticky/NoTaskForwardNoPollForwardAllowSync` | 2.0% (1/50) | 38h ago | [1](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068512) | | `TestDeploymentVersionSuiteV2/TestDeleteVersion_Drained_But_Pollers_Exist` | 2.0% (1/50) | 1h ago | [1](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456152) | | `TestVersioning3FunctionalSuiteV2/TestQueryWithPinnedOverride_Sticky/ForceTaskForwardForcePollForwardAllowSync` | 2.0% (1/50) | 38h ago | [1](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068512) | | `TestFairnessAutoEnableSuite/TestMigration_FromFair` | 2.0% (1/50) | 1h ago | [1](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456152) | | `TestVersioning3FunctionalSuiteV0/TestPinnedCaN_UpgradeOnCaN_SpeculativeWFT_NoSuggest/NoTaskForwardNoPollForwardAllowSync` | 2.0% (1/50) | 38h ago | [1](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068525) | | `TestWorkerDeploymentSuiteV0/TestDescribeWorkerDeployment_TwoVersions_Sorted` | 2.0% (1/50) | 38h ago | [1](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068512) | | `TestDeploymentVersionSuiteV2/TestDrainageStatus_SetCurrentVersion_NoOpenWFs` | 2.0% (1/50) | 1h ago | [1](https://github.com/temporalio/temporal/actions/runs/22410112796/job/64881456152) | | `TestDeploymentVersionSuiteV2/TestDeleteVersion_ValidDelete` | 2.0% (1/50) | 21h ago | [1](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512833) | | `TestScheduleFunctionalSuite/TestListSchedulesReturnsWorkflowStatus` | 2.0% (1/50) | 38h ago | [1](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068523) | | `TestVersioningFunctionalSuite/TestWorkflowTaskRedirectInRetryFirstTask/ForceTaskForwardForcePollForwardAllowSync` | 2.0% (1/50) | 60h ago | [1](https://github.com/temporalio/temporal/actions/runs/22296780641/job/64495114191) | | `TestCronTestSuite/TestCronWorkflow` | 2.0% (1/50) | 44h ago | [1](https://github.com/temporalio/temporal/actions/runs/22329840058/job/64609560092) | | `TestVersioning3FunctionalSuiteV0/TestPinnedCaN_UpgradeOnCaN_NormalWFT_WithSuggest/ForceTaskForwardNoPollForwardForceAsync` | 2.0% (1/50) | 38h ago | [1](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068420) | | `TestVersioning3FunctionalSuiteV2/TestAutoUpgradeCaN_UpgradeOnCaN/ForceTaskForwardForcePollForwardAllowSync` | 2.0% (1/50) | 38h ago | [1](https://github.com/temporalio/temporal/actions/runs/22337683305/job/64634068472) | | `TestDeploymentVersionSuiteV2/TestReactivationSignalCache_Deduplication_SignalWithStart` | 2.0% (1/50) | 60h ago | [1](https://github.com/temporalio/temporal/actions/runs/22296780641/job/64495114191) | | `TestVersioning3FunctionalSuiteV2/TestPinnedQuery_DrainedVersion_PollersAbsent/ForceTaskForwardNoPollForwardAllowSync` | 2.0% (1/50) | 21h ago | [1](https://github.com/temporalio/temporal/actions/runs/22373551837/job/64758512837) | ### Flaky Suites | Suite | Flake Rate | Last Failure | |-------|------------|-------------| | `TestAcquireShard_DeadlineExceededErrorSuite` | 2.1% (1/47) | 38h ago | | `TestAcquireShard_OwnershipLostErrorSuite` | 2.1% (1/48) | 44h ago | | `TestActivityClientTestSuite` | **8.3% (4/48)** | 1h ago | | `TestActivityTestSuite` | 2.1% (1/48) | 44h ago | | `TestAdminTestSuite` | 2.1% (1/48) | 44h ago | | `TestAdvancedVisibilitySuite` | 4.2% (2/48) | 44h ago | | `TestAdvancedVisibilitySuiteLegacy` | 2.1% (1/48) | 23h ago | | `TestCallbacksSuiteCHASM` | **8.3% (4/48)** | 1h ago | | `TestChasmTestSuiteLegacy` | 2.1% (1/48) | 44h ago | | `TestChildWorkflowSuite` | 2.1% (1/48) | 60h ago | | `TestClientDataConverterTestSuite` | **100.0% (1/1)** | 44h ago | | `TestClientMiscTestSuite` | 2.1% (1/48) | 44h ago | | `TestCronTestClientSuite` | **6.2% (3/48)** | 21h ago | | `TestCronTestSuite` | 2.1% (1/48) | 44h ago | | `TestDLQSuite` | 4.2% (2/48) | 44h ago | | `TestDeploymentVersionSuiteV0` | **62.5% (30/48)** | 1h ago | | `TestDeploymentVersionSuiteV2` | **22.9% (11/48)** | 1h ago | | `TestFairnessAutoEnableSuite` | **8.3% (4/48)** | 1h ago | | `TestFairnessSuite` | 2.1% (1/48) | 60h ago | | `TestFuncClustersTestSuite` | **8.3% (4/48)** | 1h ago | | `TestGetHistoryFunctionalSuite` | 2.1% (1/48) | 23h ago | | `TestNamespaceInterceptorTestSuite` | **6.2% (3/48)** | 38h ago | | `TestNamespaceSuite` | 1.9% (1/53) | 44h ago | | `TestNexusApiTestSuiteWithTemporalFailures` | 2.1% (1/48) | 44h ago | | `TestNexusStateReplicationTestSuite` | 2.1% (1/48) | 1h ago | | `TestNexusWorkflowTestSuite` | 2.1% (1/48) | 44h ago | | `TestPollerScalingFunctionalSuite` | 2.1% (1/48) | 44h ago | | `TestPrioritySuite` | 4.2% (2/48) | 21h ago | | `TestPurgeDLQTasksSuite` | 2.1% (1/48) | 44h ago | | `TestQueryWorkflowSuite` | 2.1% (1/48) | 38h ago | | `TestRawHistoryClientSuite` | 2.1% (1/48) | 44h ago | | `TestRelayTaskTestSuite` | 2.1% (1/47) | 44h ago | | `TestResetWorkflowTestSuite` | 2.1% (1/48) | 44h ago | | `TestScheduleFunctionalSuite` | **6.2% (3/48)** | 21h ago | | `TestStandaloneActivityTestSuite` | **10.4% (5/48)** | 1h ago | | `TestTLSFunctionalSuite` | 2.1% (1/48) | 44h ago | | `TestTaskQueueStats_Classic_Suite` | **18.8% (9/48)** | 1h ago | | `TestTaskQueueStats_Pri_Suite` | **25.0% (12/48)** | 1h ago | | `TestTaskQueueSuite` | 4.2% (2/48) | 1h ago | | `TestTransientTaskSuite` | 2.1% (1/48) | 44h ago | | `TestUpdateWorkflowSdkSuite` | 2.1% (1/48) | 44h ago | | `TestUserMetadataSuite` | 2.1% (1/47) | 44h ago | | `TestUserTimersTestSuite` | 2.1% (1/47) | 44h ago | | `TestVersionWorkflowSuite` | **20.0% (1/5)** | 21h ago | | `TestVersioning3FunctionalSuiteV0` | **100.0% (48/48)** | 1h ago | | `TestVersioning3FunctionalSuiteV2` | **100.0% (48/48)** | 1h ago | | `TestVersioningFunctionalSuite` | **10.4% (5/48)** | 1h ago | | `TestWorkerDeploymentSuiteV0` | **16.7% (8/48)** | 21h ago | | `TestWorkerDeploymentSuiteV2` | **12.5% (6/48)** | 21h ago | | `TestWorkflowMemoTestSuite` | 2.1% (1/48) | 44h ago | | `TestWorkflowTaskTestSuite` | 4.2% (2/48) | 38h ago | | `TestWorkflowUpdateSuite` | 2.1% (1/48) | 44h ago | </p> </details>
## What changed? Use a sliding window for count-min sketch cells. ## Why? Use less memory, or use more cells with the same memory. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) ## Potential risks Reduced accuracy in some extreme scenarios.
## What changed? Do not throttle panics and fatals in throttled logger ## Why? The doc block for NewThrottledLogger already says: ``` // Fatal/Panic logs are always emitted without any throttling ``` but this is not respected in the code. Changed the code to match this. ## How did you test it? - [X] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
## What changed? 1) added metric(gauge) when update fails 2) change lastUpdatedTime to lastCheckedTime and not update it for possible transient errors ## Why? may be a root cause why pods run into crashloop adding this metric for alert make debugging easier ## How did you test it? - [x] built - [x] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s)
## What changed? Add timeout to Omes in Mixed Brain test. ## Why? In [this run](https://github.com/temporalio/temporal/actions/runs/22877745566/job/66373674464?pr=9288) it took 18m for the error to surface. No need to wait that long. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
## What changed? Add a default 90s timeout to individual tests using the `testcore.NewEnv` for setup. Tests should use the `context.Context` returned from `testcore.NewEnv(...)` to fail early when a test exceeds the timeout. ## Why? Go only allows to set a timeout for an entire test run via `go test`, but a single test case can make the entire run be stuck for the full test timeout time. This change will make those tests exit early speeding up the dev process. ## How did you test it? - [ ] built - [X] run locally and tested manually - [X] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) ## Potential risks Test change only, could introduce flakes if tests did not have previous context timeouts. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches shared test infrastructure and changes how contexts/timeouts are created and propagated across functional tests, which could introduce new test flakes or premature cancellations if timeouts are too aggressive. > > **Overview** > Functional tests created via `testcore.NewEnv` now get a *test-scoped* timeout context (default **90s**, configurable via `TEMPORAL_TEST_TIMEOUT` or per-test `testcore.WithTimeout`) that is canceled on timeout and fails the test during cleanup. > > `testcore.NewContext` is updated to optionally derive from a parent context, and key functional tests are migrated to pass `s.Context()`/`env.Context()` into RPC calls and `context.WithTimeout(...)` to respect cancellations. Linting/docs are updated to discourage `context.Background()` in tests and document the new timeout knob. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 98852a5. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
## What changed? Migrated MaxBufferedEventSuite to new TestEnv. Advice to reviewer; use "Hide whitespace". ## Why? Testify suites are deprecated for functional tests. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
…temporalio#9442) ## What changed? Bumps [go.opentelemetry.io/otel/sdk](https://github.com/open-telemetry/opentelemetry-go) from 1.34.0 to 1.40.0. Fix misuse of testify assertions inside `EventuallyWithT` callbacks ## Why? testify v1.11.0 introduced a "check early" optimization where `EventuallyWithT` runs the condition immediately before the first tick. This exposed pre-existing bugs where suite-level assertions (`s.NoError`, `s.True`, etc.) were used inside `EventuallyWithT` callbacks instead of `CollectT`-based assertions. Suite assertions call `FailNow` on the real test T, killing the test immediately instead of allowing `EventuallyWithT` to retry. The cache test relied on the tick delay to accumulate hold time before measuring. ## How did you test it? - [x] built - [x] covered by existing tests - [x] added new unit test(s) -- no, fixed existing ones ## Potential risks No - test change --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
## What changed? allowing nil metricHandler for dc ## Why? more flexible for initialization ## How did you test it? - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s)
…o#9393) ## What changed? - Introduces `WorkerMetricsConfig` struct to encapsulate metric enable flags - Extracts heartbeat metrics logic into `workerMetricsEmitter` in a separate file - Consolidates metric recording into a single `emit()` method ## Why? Makes it easier to add new heartbeat-derived metrics without changing `RegistryParams`. The `workerMetricsEmitter` abstraction provides better separation of concerns between registry logic and metrics emission. ## How did you test it? - [x] built - [x] covered by existing tests ## Potential risks None - pure refactoring with no behavioral changes. Co-authored-by: Cursor <cursoragent@cursor.com>
## What changed? Support data only namespace updates and merges ## Why? optional customizations on this path ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
…emporalio#9411) ## Summary - Resolve git ref and SHA from the checked-out tree (`git rev-parse`, `git symbolic-ref`) instead of `GITHUB_REF`/`GITHUB_SHA`, which point to the dispatch branch for `workflow_dispatch` events - Auto-detect CLI version from the downloaded binary via `temporal --version` fixing the admin-tools OCI label showing "unknown" - Remove `ref` input from the manual docker build workflow -- users should dispatch from the branch they want to build from
…oralio#9389) ## What changed? Fix a race condition in GetWorkflowExecutionHistory that caused SDK workers to receive incomplete history and fail with "premature end of stream". On the last page of a paginated `GetWorkflowExecutionHistory` response, re-query mutable state to detect events that were committed to the DB between the first and last page fetches. If `freshNextEventId > continuationToken.NextEventId`, the gap is fetched from persistence and appended to the response before transient/speculative events are added. The continuation token is updated with the fresh boundary so `appendTransientTasks` validates against the correct `NextEventId`. If the re-query itself fails, the request returns an error so the client retries. Also adds a `nil` check in `ValidateTransientWorkflowTaskEvents`, preventing a possible nil-pointer dereference. ## Why? A speculative WFT is converted to normal (e.g., by an incoming signal), committing 1–2 new events. The continuation token from page 1 points to NextEventId=8; the DB range [6, 8) on page 2 returns only events 6–7, missing the newly-committed events 8 and 9. `appendTransientTasks` finds no transient tasks (speculative was committed), so the assembled history is missing 2 events. ## How did you test it? - [X] built - [X] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [X] added new functional test(s) ## Potential risks - The re-query on the last history page adds one extra GetMutableState RPC per paginated `GetWorkflowExecutionHistory` call. This is bounded to final-page responses only and the existing path already made this call inside `appendTransientTasks`, so the net overhead is one additional call specifically when a gap is detected. - Returning an error when the fresh mutable-state re-query fails changes the previous behavior of silently continuing. Clients will retry, which is correct, but retry storms are possible if persistence is consistently unavailable mitigated by the client's existing backoff.
## What changed? Switch functional tests to new matcher. ## Why? This will be the default soon, ensure test coverage.
## What changed? - Add AdminClient to testcore.Env interface - Add taskpoller.CompleteWorkflowHandler - simple handler to always complete a workflow - Add metricstest.CaptureSnapshot type alias - this makes it easier to pass snapshots to helper functions ## Why? Make tests easier to write. ## How did you test it? - [ ] built - [x] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [x] added new functional test(s) - these are used by functional tests to be sent in future PRs
## What changed? rm setMetricsHandler of FilebasedDCClient ## Why? rm redundancy ## How did you test it? - [x] built - [ ] run locally and tested manually - [x] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
## What changed? Do another call to `tr.maybeReadTasksLocked()` here (after setting `tr.readPending = false`) in case the backoff timer runs before the rest of `tr.readTasksImpl` runs. ## Why? There's a race between the backoff timer and the rest of `readTasksImpl`: if the backoff timer runs first it'll think there's still a read pending and give up. So we can do a final check if we should read tasks before finishing `readTasksImpl`. Note that if it does decide to read then, the next read will be in another goroutine. ## How did you test it? - [ ] built - [x] run locally and tested manually (tested with manual hook and fault injection) - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
## What changed? Add a check that passes through serviceerror ResourceExhausted in gocql ConvertError. Also add unit test for ConvertError. ## Why? In case gocql is wrapped or intercepted by systems that provide rate limiting or flow control. ## How did you test it? Added unit tests.
…o#9418) ## What changed? - Build `WorkerListInfo` in matching handler and pass through to frontend - Update `go.temporal.io/api` to include merged WorkerListInfo proto ## Why? `WorkerListInfo` contains only static worker attributes for efficient listing. Building it in matching (closer to the data source) enables eventually dropping the deprecated `WorkersInfo` field from the internal response. ## How did you test it? - [x] built - [x] added new unit test for field coverage - [x] covered by existing functional tests ## Potential risks None - backward compatible. Deprecated `WorkersInfo` field continues to be populated.
## What changed? Unify MustToPayload test helper. ## Why? Single helper. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…alio#9349) Bumps [filippo.io/edwards25519](https://github.com/FiloSottile/edwards25519) from 1.1.0 to 1.1.1. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/FiloSottile/edwards25519/commit/d1c650afb95fad0742b98d95f2eb2cf031393abb"><code>d1c650a</code></a> extra: initialize receiver in MultiScalarMult</li> <li>See full diff in <a href="https://github.com/FiloSottile/edwards25519/compare/v1.1.0...v1.1.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/temporalio/temporal/network/alerts). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Use tagged API 1.62.3 for cloud release purposes. This tag includes the api-go psuedo-version already in the go.mod. --------- Co-authored-by: Chris St. Pierre <chris.st-pierre@temporal.io>
## What changed? Add default testhooks.NewHook impl that panics. ## Why? Only a few tests use testhooks.NewHook; by adding this default impl, the others can be run without using `-tags test_dep`. This is particularly useful with agentic coding as it reduces friction. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
## What changed?
Add t.Parallel() to all TestEnv suites.
## Why?
Each test case automatically becomes parallel when using TestEnv; but
the wrapper test ("suite") must still manually be marked as parallel.
## How did you test it?
- [ ] built
- [ ] run locally and tested manually
- [x] covered by existing tests
- [ ] added new unit test(s)
- [ ] added new functional test(s)
## What changed? - Added the 'tdbg schedule migrate' command ## Why? - Allows us an operator to manually trigger a migration (roll forward or backward) to a schedule via tdbg CLI ## How did you test it? - Tested manually with V1->CHASM direction. Verified (via `temporal` and `tdbg`) CHASM scheduler was created, V1 scheduler workflow closed successfully.
## What changed? Emit task dispatch latency metric in matching_engine with the following improvements: - latency includes history calls - latency is not reset in case of sync-match forwards - metric is not lost for backlogged task in new matcher - origin partition is preserved during forward and used at the partition tag in the metric (keeping existing behavior) - task and poll forwarding do not cause duplicate emits, keeping existing behavior Also, fixed the following unrelated bugs that surfaced while testing the metric: - Query priority is not lost when forwarded. ## Why? Fixes bugs. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [x] added new functional test(s) ## Potential risks None.
## What changed? Implement DeleteExecution method in CHASM engine. ## Why? Support explicit deletion of CHASM executions. When this is called, the execution is terminated if still running. If the execution is still running, the current transaction's visibility task will be skipped and will immediately follow with DeleteExecutionVisibilityTask. If already terminated, CloseExecutionVisibilityTaskID will be updated with the latest CHASM visibility task ID. Reuses DeleteExecutionTask to delete execution info. ## How did you test it? - [X] built - [X] run locally and tested manually - [X] covered by existing tests - [X] added new unit test(s) - [X] added new functional test(s)
## What changed? When `ListWorkersEnabled` dynamic config is disabled for a namespace, `ListWorkers` and `DescribeWorker` APIs now return empty responses instead of `Unimplemented` errors. ## Why? Callers shouldn't need to handle errors for a feature that's simply not enabled yet. ## How did you test it? - [x] built - [x] covered by existing tests ## Potential risks None
## What changed? - Add ApplySystemMutation method on chasm tree for force applying any cluster specific chasm tree changes. ## Why? - Allow cluster specific chasm tree changes. ## How did you test it? - [x] built - [ ] run locally and tested manually - [x] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
…emporalio#9485) Cassandra returns CAS batch result rows in clustering key order, while ScyllaDB returns them in statement order. The nexus endpoint store assumed Cassandra's ordering, causing the partition-status and endpoint rows to be swapped on ScyllaDB. ## What changed? Add classifyBatchCASRows() that inspects the "type" column to assign rows to their correct roles regardless of iteration order. Reorder the DELETE batch so the table-version update comes first, satisfying both databases' ordering. ## Why? See above. ## How did you test it? - [x] built - [x] run locally and tested manually - against both. - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) ## Potential risks Verified it works well against both.
## Why? Run faster. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) Ran it 3x locally and they passed 3x (wasn't the case before temporalio#9390)
## What changed? Add full commit SHA tags alongside the existing short SHA tags for OSS `server` and `admin-tools` images. The Docker build action now emits both tag forms, Docker bake publishes both tags, and the manual Docker build summary shows the short SHA tag, full SHA tag, and branch tag from action outputs. ## Why? This repo has outgrown 7-character SHA uniqueness, so short SHA tags can collide. Since release engineering automation publishes and consumes these image tags across workflows, using full SHAs keeps artifact selection deterministic while preserving short tags for compatibility. ## How did you test it? - [x] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) --------- Co-authored-by: Alex Stanfield <13949480+chaptersix@users.noreply.github.com>
## What changed? Update to the latest release of the API module. ## Why? Support the 3.152 cloud release. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
## What changed? Adding the visibility precondition check to the other tests that are utilizing force replication to wait for visibility to catch up. ## Why? flakiness go byebye? ## How did you test it? - [x] built - [x] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
- Use `errors.AsType` instead of `errors.As` - Use `require.ErrorContains` instead of two separate assertions (`require.Error` + `require.Contains`)
…ble (temporalio#9372) ## What changed? - made the test work - removed 10s sleep ## Why? The test never worked ... if you remove the 10s sleep it still succeeds. The missing piece was that you _first_ have to poll to kickoff the 10s timeout. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
…orker (temporalio#9544) ## What changed? Deprecate `ListWorkersEnabled` dynamic config flag. `ListWorkers` and `DescribeWorker` APIs are now always enabled — they naturally return empty/NotFound when no heartbeat data exists, so the flag is unnecessary. The write path is already gated by `WorkerHeartbeatsEnabled`. Follow-up to temporalio#9531. ## How did you test it? - [x] built - [x] added new functional test(s) ## Potential risks None — the flag defaulted to `true` and the config key is preserved (deprecated) to avoid parse errors.
… all user-facing APIs (temporalio#9430) ## What changed? Add internal task queue name validation for standalone activities. Harden /_sys/ prefix validation in NormalizeAndValidateUserDefined, which also applies to StartWorkflow, SignalWithStart, Schedules, ContinueAsNew, and StartChild. Polish error messages. Split up activity task queue validation between standalone and embedded. ## Why? We should guard against users specifying task queue names and prefixes reserved for internal purposes. Embedded activities still must allow PerNSWorkerTaskQueue since they can be used internally today. ## How did you test it? - [X] built - [X] run locally and tested manually - [X] covered by existing tests - [X] added new unit test(s) - [ ] added new functional test(s)
…alio#9520) Remove usage of github.com/pkg/errors and replace with standard library errors and fmt.Errorf wrapping. Changes: - common/finalizer/finalizer.go - service/worker/migration/activities.go - remove pkg/errors direct dependency via go mod tidy Addresses part of temporalio#9244 ## What changed? - Replaced `github.com/pkg/errors` with Go standard library `errors` in `common/finalizer/finalizer.go` (only uses `errors.New`) - Replaced `errors.WithMessage` with `fmt.Errorf` and `%w` in `service/worker/migration/activities.go` - Dropped direct `pkg/errors` dependency from `go.mod`; it remains as an indirect dependency from `uber-go/tally` ## Why? `github.com/pkg/errors` is deprecated and unmaintained. The standard library `errors` and `fmt.Errorf` with `%w` cover the same use cases and support `errors.Is` and `errors.As` for error unwrapping. ## How did you test it? - [x] built - [x] run locally and tested manually - [x] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) ## Potential risks None. The changes are localized and behavior is unchanged; tests for the modified packages pass. pleas commti and push it There’s nothing new to commit: the working tree has no staged or modified files. The pkg/errors changes are already committed and pushed on remove-pkg-errors (commit 52dbb1d). The only untracked items are test artifacts under common/persistence/tests/test_0315064513_*, which look like temporary files and shouldn’t be committed. --------- Co-authored-by: alex.stanfield <13949480+chaptersix@users.noreply.github.com>
## What changed? WISOTT ## Why? Part of a piece by piece migration of functional tests to use `TestEnv` ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) ## Potential risks Tests only
…mporalio#9480) PublishToNamespaceDLQ used only 5 retries while the equivalent Publish() helper uses 20. Under 10-way concurrent LWT contention this is insufficient, causing flaky TestNamespaceReplicationDLQ failures. ## What changed? Just the number of retries. ## Why? Under load, it was flaky, adding more retries made sense. ## How did you test it? - [x] built - [x] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) ## Potential risks I don't see any potential risks here. Might cause some tests to run slower - if they need to, instead of failing. A good thing(TM).
temporalio#9479) ## What changed? When a workflow is reset, `ApplyWorkflowExecutionStartedEvent` re-registers the start-event callbacks using the reset operation's request ID. `HandleNexusCompletion` cannot find a matching `BufferedStart` and discards the completion. The `resetRequestID` param is removed from `WorkflowResetter.ResetWorkflow` and the original request ID is used. `findStartRequestID` reads the original request ID back from `WorkflowExecutionInfo.RequestIds` by finding the `EVENT_TYPE_WORKFLOW_EXECUTION_STARTED` entry. ## Why? CHASM scheduler relies on callback `request_id` to match WF completions to originating `BufferedStart` entries. When it cannot be found the scheduler is permanently stuck with the workflow marked as still running. ## How did you test it? - [X] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [X] added new functional test(s) - `TestScheduledWorkflowDoubleReset_SchedulerSeesCompletion_{HSM,CHASM}Callbacks`: create a schedule, trigger immediately, reset the workflow twice, signal the completion to complete, poll `ListSchedules` until scheduler shows `COMPLETED`. ## Potential risks CHASM scheduler has not been enabled in production yet, the blast radius should be minimal.
## What changed? Rename `FunctionalTestBase`'s `Worker` to `SdkWorker`. ## Why? The new TestEnv uses `SdkClient/SdkWorker`; with this change the diff on individual suite migrations is greatly reduced. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
## What changed? Changed chasm engine to convert errors, if needed, to the relevant service errors. Chasm errors remain as is. Internal errors (i.e., persistence) are sanitized and error details for uncategorized errors are preserved via logging. Uncategorized errors are defaulted to serviceerror.Unavailable ## Why? Currently chasm engine can expose non-service errors with internal details. We should not expose this to the API callers as those errors may eventually be exposed publicly. But we do want to preserve the original errors for debugging purposes, and thus they get logged before the conversion. ## How did you test it? - [X] built - [X] run locally and tested manually - [X] covered by existing tests - [X] added new unit test(s) - [ ] added new functional test(s)
## What changed? WISOTT ## Why? Failed in a previous test run: https://github.com/temporalio/temporal/actions/runs/23258145881/job/67619316218 ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) ## Potential risks NA, tests only
…lio#9568) ## What changed? - Added `BuildId` as a supported query attribute in `worker_query_engine.go` (was documented in proto but missing from implementation) - Added `Status` query support by registering the lowercased form (`status`) that the SQL parser produces for reserved words, using `sqlparser.String()` + backtick strip consistent with the rest of the codebase - Kept `WorkerStatus` as a backward-compatible alias - Fixed stale comment references (`LastHeartbeatTime` → `HeartbeatTime`) ## Why? `BuildId` and `Status` are documented as supported query attributes in `ListWorkersRequest` proto but were not working. `BuildId` was entirely missing from the property map, and `Status` is a SQL reserved word so the parser lowercases and backtick-quotes it — the old code used `WorkerStatus` which didn't match the proto docs. ## How did you test it? - [x] built - [x] covered by existing tests - [x] added new unit test(s)
## What changed?
Fix a panic in `TestTaskQueueStats_{Classic,Pri}_Suite` when tests run
in parallel. The outer `t *testing.T` was passed to the suite and a
panic occurred outside of the testing context.
Sample: https://github.com/temporalio/temporal/actions/runs/23262976802
## Why?
Previously enabled parallel execution which caused this bug more
frequently.
## How did you test it?
- [ ] built
- [ ] run locally and tested manually
- [X] covered by existing tests
- [ ] added new unit test(s)
- [ ] added new functional test(s)
## Potential risks
Test only
…alio#9431) ## What changed? Publish metrics for storage driver types that are passed from SDK through worker heartbeat. This is only enabled if ExternalPayloadsEnabled is set to true. ## Why? SDK sends the storage driver types used for storing large external payloads. We'd like to publish them as metrics in order to gauge the usage. ## How did you test it? - [X] built - [X] run locally and tested manually - [X] covered by existing tests - [X] added new unit test(s) - [ ] added new functional test(s) ## Potential risks High metric cardinality for Temporal Cloud, so should be logged to Chronicle.
Merges temporalio/temporal main branch up to df2e384. Key upstream changes: - Customizable serialization (temporalio#8426): EncodingTypeFromEnv(), EncodingType() on Encoder - Per-workflow scheduler for history task processing (temporalio#9141) - Ringpop membership & PerNamespaceWorker reusability (temporalio#9321) - Transient/speculative WFT events in history response (temporalio#9325) - Per-check diagnostics in DeepHealthCheck API (temporalio#9350) - Fairness counter heap bug fix (temporalio#9370) - System nexus endpoint (temporalio#9002) - Mixed brain non-blocking (temporalio#9406) - interface{} → any across persistence layer - Various CI, test, and chasm improvements DSQL fork code preserved: - TxRetryPolicy/TxRetryMetrics/TxRetryPolicyProvider (common.go) - ExecutionStoreCreator interface and factory wrapping (factory.go) - OCC-aware lockShard bypass (shard.go) - PoolSizeHint ephemeral pool sizing (version_checker.go) - DSQL-safe InitializeSystemNamespaces (metadata_manager.go) - Snowflake ID generator (idgenerator.go) - RegisterPluginAlias (store.go) - Full DSQL plugin (sqlplugin/dsql/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges temporalio/temporal main branch (124 commits since last merge at f346de0).
Key upstream changes
DSQL fork code preserved
Verification
go build ./...passes clean