Bug: Remove reciprocal from monotonic decreasing ops#25535
Merged
tensorflow-copybara merged 1 commit intotensorflow:masterfrom Feb 9, 2019
Merged
Bug: Remove reciprocal from monotonic decreasing ops#25535tensorflow-copybara merged 1 commit intotensorflow:masterfrom
tensorflow-copybara merged 1 commit intotensorflow:masterfrom
Conversation
ezhulenev
approved these changes
Feb 6, 2019
Contributor
|
Whoah, that's scary. |
rmlarsen
approved these changes
Feb 6, 2019
Contributor
rmlarsen
left a comment
There was a problem hiding this comment.
Thanks for catching this.
tensorflow-copybara
pushed a commit
that referenced
this pull request
Feb 9, 2019
PiperOrigin-RevId: 233138653
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1 / xhas an infinite discontinuity atx = 0(https://www.wolframalpha.com/input/?i=1+%2F+x). Thus it is not monotonic on the entire real line.The algorithmic optimizer would optimize the case
Max(Inv(x)) => Inv(Min(x)). But this is only true forx > 0orx < 0. E.g.:This PR removes
InvandReciprocalops from the list of elementwise monotonic ops.Fixes #25330 (comment)
/cc @ezhulenev