-
-
Notifications
You must be signed in to change notification settings - Fork 275
feat!: Upgrade MSV of AWS provider to 6.20, remove support for origin access identities
#177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c422848 to
b3e86c7
Compare
|
|
||
| - [Complete](https://github.com/terraform-aws-modules/terraform-aws-cloudfront/tree/master/examples/complete) - Complete example which creates AWS CloudFront distribution and integrates it with other [terraform-aws-modules](https://github.com/terraform-aws-modules) to create additional resources: S3 buckets, Lambda Functions, CloudFront Functions, VPC Origins, ACM Certificate, Route53 Records. | ||
|
|
||
| ## Notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now solved by these added guards (both default and ordered cache behaviors) so users don't need to worry about this https://github.com/terraform-aws-modules/terraform-aws-cloudfront/pull/177/files#diff-dc46acf24afd63ef8c556b77c126ccc6e578bc87e3aa09a931f33d9bf2532fbbR36-R37
antonbabenko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! +1 for simplifying OAC vs OAI. I am always confused which one I should use. :)
|
This PR is included in version 6.0.0 🎉 |
List of backwards incompatible changes
v6.20is now minimum supported versionaws_cloudfront_origin_access_identityhas been removed in favor ofaws_cloudfront_origin_access_controlAdditional changes
Added
Modified
objecttypes in place of the previously used any typeis_ipv6_enablednow defaults totrueif not specifieddefault_cache_behavior.compressandordered_cache_behavior.compressnow default totrueorigin.origin_ssl_protocolsnow defaults to["TLSv1.2"]vpc_origin.origin_ssl_protocols.itemsnow defaults to["TLSv1.2"]vpc_origin_timeoutsis now embedded undervpc_originviewer_certificate.minimum_protocol_versionnow defaults to"TLSv1.2_2025"Before vs Afterexamples below for more details on variable type definition changesVariable and output changes
Removed variables:
create_origin_access_identityorigin_access_identitiescreate_origin_access_controlcreate_vpc_originvpc_origin_timeouts- usetimeoutsblock withinvpc_originvariable insteadcreate_response_headers_policycreate_cloudfront_functionRenamed variables:
create_distribution->createAdded variables:
anycast_ip_list_idRemoved outputs:
cloudfront_vpc_origin_idscloudfront_origin_access_controls_idscloudfront_origin_access_identitiescloudfront_origin_access_identity_idscloudfront_origin_access_identity_iam_arnscloudfront_distribution_tagsRenamed outputs:
Added outputs:
cloudfront_vpc_originsMotivation and Context
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request