Conversation
…efresh code, reconfigure plot generation to display cultivar-specific data as superimposed points
…e; disable annoying scrolling
…rovements, refactor for readability
|
Do you have a demo? |
|
Unfortunately I cannot set up an SSH tunnel on Shinyapps.io, but @robkooper set up a VM for me to deploy it to, and I will do my best to make that happen tomorrow. |
| library(lubridate) | ||
| options(scipen=999) | ||
|
|
||
| # set up remote connection to BETYdb |
There was a problem hiding this comment.
@nickheyek it wasn't clear from the README how to set these up. is it just putting
export bety_user=bety
export bety_password=...
...in .bashrc?
Since access is restricted by ssh, I just hard coded the values. (see below). Does that make sense?
There was a problem hiding this comment.
Sorry. Export works in bash, or Sys.setenv() in R. Hard coding it in is also okay, I used environment variables out of concern for leaving passwords in Github.
| ) | ||
| timevis(timelineData) | ||
| # load 'full_cache_data' object from cache file | ||
| load('cache.RData') |
There was a problem hiding this comment.
This file does not exist. Simple solution would be to add (at least a small sample one) to the repository.
There was a problem hiding this comment.
A better solution would be to check if the file exists and if not, to run the script to generate it.
| rownames(seasons) <- paste0('[', seasons$start_date, ']', ' - ', '[', seasons$end_date, ']') | ||
| # schedule daily execution of cache refresh | ||
| cache_update_cmd <- cron_rscript('cache-refresh.R') | ||
| try(cron_add(command = cache_update_cmd, frequency = 'daily', |
There was a problem hiding this comment.
Would it make sense to replace this with:
if(!grepl('cache-update', cronR::cron_ls())){
cron_add(command = cache_update_cmd, frequency = 'daily',
id = 'cache-update', description = 'daily update of BETYdb cache')
}updated README
- use geom_violin under boxplot - add points to lines for specific cultivar - change figure title
… bety6 - refactored dplyr code to use lazy eval and semi-joins instead of filter - removed outline from plot colors - changed basemap to semi-useful default
Shiny app edits
2 participants
No description provided.