Bump the Bundle Support and Source pins - #49
Merged
Conversation
Both embedded copies predated fixes that are already on their repos' main, and Managed/Bundles takes precedence over the app's SharedSupport only if the user has a managed copy — a fresh install ran the stale ones. Bundle Support 686adb59 -> bda1fda1 picks up: 1536a19 Fix the shelltokenize regexp for Ruby 1.9+ 8ed07d3 modernize File.exists? and ERB.new calls (thanks @mattneub) shelltokenize.rb failed to parse at all under the system Ruby, which broke every command that required it, whatever shebang it carried: lib/shelltokenize.rb:75: invalid multibyte escape: /[^\w_\-\+=\/\x7F-\xFF]/ Source 2c873f83 -> 678a8db1 picks up: 751aa5e Replace ruby18 shebangs with the system ruby Text and Themes are already pinned at their current main, so fetch_embedded_bundles.sh skips them. src/default.rave comes along because the script materializes the whole tarball and its sibling src/find_app.cc was already tracked. Verified after re-vendoring: shelltokenize parses, no ruby18/ruby20 and no -K anywhere under the embedded bundles, and ruby -c is clean across every embedded .rb.
This was referenced Aug 27, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both embedded copies predated fixes that are already on their repos'
main.Managed/Bundlesshadows the app'sSharedSupportonly when the user has a managed copy — a fresh install was running the stale ones.Bundle Support
686adb59→bda1fda1:1536a19Fix the shelltokenize regexp for Ruby 1.9+8ed07d3modernizeFile.exists?andERB.newcalls (thanks @mattneub)shelltokenize.rbfailed to parse under the system Ruby, sorequire "shelltokenize"raisedSyntaxErrorand broke every command that required it, whatever shebang it carried:Source
2c873f83→678a8db1:751aa5eReplace ruby18 shebangs with the system rubyText and Themes are already pinned at their current
main, sofetch_embedded_bundles.shskips them.src/default.raveis picked up because the script materializes the whole tarball and its siblingsrc/find_app.ccwas already tracked. It exists at the old pin too — it just was never committed.Verified
shelltokenize.rbparses, noruby18/ruby20and no-Kanywhere underApplications/TextMate/support/Bundles,ruby -cclean across every embedded.rb.bin/fetch_embedded_bundles.shis idempotent — a second run reports[skip]for all four and leaves the tree clean..appships the fixed copies.Refs #45