Skip to content

Comments

New Tutorial Effect Estimation, more Links in Tutorials#877

Merged
Zethson merged 55 commits intomainfrom
revampedTutorial
Apr 1, 2025
Merged

New Tutorial Effect Estimation, more Links in Tutorials#877
Zethson merged 55 commits intomainfrom
revampedTutorial

Conversation

@aGuyLearning
Copy link
Collaborator

@aGuyLearning aGuyLearning commented Mar 7, 2025

PR Checklist
closes #876
closes #744

  • This comment contains a description of changes (with reason)
  • Referenced issue is linked
  • Documentation in docs is updated
  • Multivariate coxph example
  • Tableone case study from chapter 16

Description of changes
This pull request includes several changes to improve the clarity and consistency of the text in the tutorials. The most important changes include standardizing the formatting of code identifiers, and improving the readability of certain sections. As well as linking to the documentation for mentioned functions and classes.

@eroell
Copy link
Collaborator

eroell commented Mar 7, 2025

Nice! Could we also use this to show an additional example with brief explanation to show how your recent additions for #744 work?

@aGuyLearning
Copy link
Collaborator Author

Nice! Could we also use this to show an additional example with brief explanation to show how your recent additions for #744 work?

Will do, currently just using this pr to check out how to make nbspinx link to the documentation

@aGuyLearning aGuyLearning marked this pull request as draft March 7, 2025 08:58
@aGuyLearning aGuyLearning self-assigned this Mar 7, 2025
@eroell eroell self-requested a review March 13, 2025 09:09
Copy link
Collaborator

@eroell eroell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments, also on the ehrapy-tutorials repo

@github-actions github-actions bot added the chore label Mar 13, 2025
@eroell eroell force-pushed the revampedTutorial branch from bd3584a to fef05f2 Compare March 19, 2025 08:22
@eroell eroell changed the title Improve Tutorial Clarity, Consistency, and Documentation Links New Tutorial Effect Estimation, more Links in Tutorials Mar 19, 2025
@eroell eroell marked this pull request as ready for review March 19, 2025 10:09
@eroell eroell requested a review from Zethson March 19, 2025 11:02
Zethson added 4 commits April 1, 2025 22:34
Signed-off-by: Lukas Heumos <lukas.heumos@posteo.net>
Signed-off-by: Lukas Heumos <lukas.heumos@posteo.net>
Signed-off-by: Lukas Heumos <lukas.heumos@posteo.net>
@Zethson Zethson merged commit daa0f59 into main Apr 1, 2025
11 checks passed
@Zethson Zethson deleted the revampedTutorial branch April 1, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation Enhancement: Improve Tutorial(s) on IAC from Secondary Analysis of Electronic Health Records Multivariate and regularized CoxPH models

3 participants