Skip to content

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Sep 26, 2024

PR-Codex overview

This PR primarily focuses on replacing icons from the @react-icons/all-files library with equivalent icons from the lucide-react library across various components, enhancing consistency and potentially improving performance.

Detailed summary

  • Removed IconType prop from several interfaces.
  • Replaced @react-icons/all-files icons with lucide-react icons in components like HackathonFooter, NFTClaimButton, SelectOption, and others.
  • Updated icon usage in the MobileNavSection and NavCard.
  • Adjusted styling for new icons where necessary.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2024

⚠️ No Changeset found

Latest commit: ebd5908

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 1:21am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Sep 27, 2024 1:21am
thirdweb_playground ⬜️ Skipped (Inspect) Sep 27, 2024 1:21am
wallet-ui ⬜️ Skipped (Inspect) Sep 27, 2024 1:21am

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 26, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Sep 26, 2024
@codecov
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.67%. Comparing base (21b032d) to head (ebd5908).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4810   +/-   ##
=======================================
  Coverage   47.67%   47.67%           
=======================================
  Files        1051     1051           
  Lines       56715    56715           
  Branches     3894     3894           
=======================================
  Hits        27040    27040           
  Misses      28988    28988           
  Partials      687      687           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 21b032d
packages 43.40% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.93 KB (0%) 839 ms (0%) 3.8 s (+55.02% 🔺) 4.6 s
thirdweb (cjs) 101.55 KB (0%) 2.1 s (0%) 7.1 s (-1.25% 🔽) 9.1 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 238 ms (-22.97% 🔽) 334 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 365 ms (+599.07% 🔺) 375 ms
thirdweb/react (minimal + tree-shaking) 16.78 KB (0%) 336 ms (0%) 968 ms (-0.73% 🔽) 1.4 s

@kien-ngo kien-ngo force-pushed the kien/remove-react-icons branch from fea903e to 4e31040 Compare September 26, 2024 09:38
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 26, 2024 09:38 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 26, 2024 09:38 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 26, 2024 09:38 Inactive
@kien-ngo kien-ngo force-pushed the kien/remove-react-icons branch from 4e31040 to 0b6f6e5 Compare September 26, 2024 12:14
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 26, 2024 12:14 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 26, 2024 12:14 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 26, 2024 12:14 Inactive
@kien-ngo kien-ngo changed the title [Dashboard] Remove non-branding React icons [Dashboard] Remove non-branding icons Sep 26, 2024
Copy link
Member

@MananTank MananTank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

address all comments

Copy link
Member

@MananTank MananTank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 27, 2024

Merge activity

<!-- start pr-codex -->

## PR-Codex overview
This PR focuses on replacing various `react-icons` with `lucide-react` icons across multiple components, along with some minor adjustments to properties and imports. It aims to standardize icon usage within the codebase.

### Detailed summary
- Removed `IconType` from multiple interfaces in `types.ts` and `AnimatedCLICommand.tsx`.
- Replaced `react-icons` with `lucide-react` icons in `HackathonFooter`, `NFTClaimButton`, and other components.
- Updated icon rendering logic in multiple components for consistency.
- Adjusted imports and usage of icons in `FileInput`, `BatchLazyMint`, and `MismatchButton`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the kien/remove-react-icons branch from 7d5099a to ebd5908 Compare September 27, 2024 01:11
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 27, 2024 01:11 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 27, 2024 01:11 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 27, 2024 01:11 Inactive
@graphite-app graphite-app bot merged commit ebd5908 into main Sep 27, 2024
@graphite-app graphite-app bot deleted the kien/remove-react-icons branch September 27, 2024 01:21
@vercel vercel bot temporarily deployed to Production – wallet-ui September 27, 2024 01:21 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground September 27, 2024 01:21 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 September 27, 2024 01:21 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants