-
Notifications
You must be signed in to change notification settings - Fork 620
[Dashboard] Remove non-branding icons #4810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4810 +/- ##
=======================================
Coverage 47.67% 47.67%
=======================================
Files 1051 1051
Lines 56715 56715
Branches 3894 3894
=======================================
Hits 27040 27040
Misses 28988 28988
Partials 687 687
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
fea903e to
4e31040
Compare
4e31040 to
0b6f6e5
Compare
apps/dashboard/src/components/hackathon/HacakthonEarnFooter.tsx
Outdated
Show resolved
Hide resolved
apps/dashboard/src/core-ui/batch-upload/lazy-mint-form/select-option.tsx
Outdated
Show resolved
Hide resolved
MananTank
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
address all comments
0b6f6e5 to
7d5099a
Compare
MananTank
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Merge activity
|
<!-- start pr-codex -->
## PR-Codex overview
This PR focuses on replacing various `react-icons` with `lucide-react` icons across multiple components, along with some minor adjustments to properties and imports. It aims to standardize icon usage within the codebase.
### Detailed summary
- Removed `IconType` from multiple interfaces in `types.ts` and `AnimatedCLICommand.tsx`.
- Replaced `react-icons` with `lucide-react` icons in `HackathonFooter`, `NFTClaimButton`, and other components.
- Updated icon rendering logic in multiple components for consistency.
- Adjusted imports and usage of icons in `FileInput`, `BatchLazyMint`, and `MismatchButton`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
7d5099a to
ebd5908
Compare

PR-Codex overview
This PR primarily focuses on replacing icons from the
@react-icons/all-fileslibrary with equivalent icons from thelucide-reactlibrary across various components, enhancing consistency and potentially improving performance.Detailed summary
IconTypeprop from several interfaces.@react-icons/all-filesicons withlucide-reacticons in components likeHackathonFooter,NFTClaimButton,SelectOption, and others.MobileNavSectionandNavCard.