Skip to content

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Sep 26, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR introduces a new LinkedInIcon component and replaces the usage of the SiLinkedin icon from react-icons with the new component in two files, enhancing the icon's integration and potentially its styling.

Detailed summary

  • Added a new LinkedInIcon component in apps/dashboard/src/components/icons/brand-icons/LinkedinIcon.tsx.
  • Replaced SiLinkedin with <LinkedInIcon /> in:
    • apps/dashboard/src/components/footer/socialLinks.tsx
    • apps/dashboard/src/components/contract-components/publisher/PublisherSocials.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2024

⚠️ No Changeset found

Latest commit: c31f919

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 2:45am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Sep 27, 2024 2:45am
thirdweb_playground ⬜️ Skipped (Inspect) Sep 27, 2024 2:45am
wallet-ui ⬜️ Skipped (Inspect) Sep 27, 2024 2:45am

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 26, 2024 16:53 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 26, 2024 16:53 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 26, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel vercel bot temporarily deployed to Preview – docs-v2 September 26, 2024 16:53 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Sep 26, 2024
@kien-ngo kien-ngo changed the title Replace Linkedin icon [Dashboard] Replace Linkedin icon Sep 26, 2024
@kien-ngo kien-ngo marked this pull request as ready for review September 26, 2024 16:53
@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.93 KB (0%) 839 ms (0%) 1.8 s (-47.21% 🔽) 2.6 s
thirdweb (cjs) 101.55 KB (0%) 2.1 s (0%) 4.4 s (-8.76% 🔽) 6.4 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 270 ms (-28.52% 🔽) 366 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 169 ms (+211.15% 🔺) 179 ms
thirdweb/react (minimal + tree-shaking) 16.78 KB (0%) 336 ms (0%) 780 ms (+52.62% 🔺) 1.2 s

@codecov
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.67%. Comparing base (ffcd199) to head (c31f919).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4818   +/-   ##
=======================================
  Coverage   47.67%   47.67%           
=======================================
  Files        1051     1051           
  Lines       56715    56715           
  Branches     3894     3894           
=======================================
  Hits        27040    27040           
  Misses      28988    28988           
  Partials      687      687           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from ffcd199
packages 43.40% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@kien-ngo kien-ngo force-pushed the kien/replace-twitter-icon branch from 3c8b546 to c8745ff Compare September 27, 2024 01:32
@kien-ngo kien-ngo force-pushed the kien/replace-linkedin-icon branch from 8abe611 to 80f4881 Compare September 27, 2024 01:32
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 27, 2024 01:32 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 27, 2024 01:32 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 27, 2024 01:32 Inactive
@MananTank MananTank force-pushed the kien/replace-twitter-icon branch from c8745ff to 814ce6c Compare September 27, 2024 01:41
@MananTank MananTank force-pushed the kien/replace-linkedin-icon branch from 80f4881 to ba39ada Compare September 27, 2024 01:42
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 27, 2024 01:42 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 27, 2024 01:42 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 27, 2024 01:42 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 27, 2024

Merge activity

@kien-ngo kien-ngo force-pushed the kien/replace-twitter-icon branch from 814ce6c to 60beea0 Compare September 27, 2024 02:37
@kien-ngo kien-ngo force-pushed the kien/replace-linkedin-icon branch from ba39ada to 5570651 Compare September 27, 2024 02:37
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 27, 2024 02:37 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 27, 2024 02:37 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 27, 2024 02:37 Inactive
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces a new `LinkedInIcon` component and replaces instances of the `SiLinkedin` icon with the new `LinkedInIcon` in two files, enhancing the consistency of icon usage across the application.

### Detailed summary
- Created a new `LinkedInIcon` component in `LinkedinIcon.tsx`.
- Replaced `SiLinkedin` with `LinkedInIcon` in `socialLinks.tsx`.
- Replaced `SiLinkedin` with `LinkedInIcon` in `PublisherSocials.tsx`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@kien-ngo kien-ngo force-pushed the kien/replace-twitter-icon branch from 60beea0 to ffcd199 Compare September 27, 2024 02:41
@kien-ngo kien-ngo force-pushed the kien/replace-linkedin-icon branch from 5570651 to c31f919 Compare September 27, 2024 02:42
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 27, 2024 02:42 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 27, 2024 02:42 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 27, 2024 02:42 Inactive
Base automatically changed from kien/replace-twitter-icon to main September 27, 2024 02:45
@graphite-app graphite-app bot merged commit c31f919 into main Sep 27, 2024
@graphite-app graphite-app bot deleted the kien/replace-linkedin-icon branch September 27, 2024 02:46
@vercel vercel bot temporarily deployed to Production – wallet-ui September 27, 2024 02:46 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground September 27, 2024 02:46 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 September 27, 2024 02:46 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants