Skip to content

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Sep 26, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on replacing icon imports for JavaScript and TypeScript with custom components, enhancing the visual representation in various components.

Detailed summary

  • Replaced SiJavascript with JavaScriptIcon in:
    • ConnectPlaygroundButton.tsx
    • CodeOptionButton.tsx
    • CodeSegment.tsx
  • Replaced SiTypescript with TypeScriptIcon in:
    • SupportedPlatformLink.tsx
    • ConnectSDKCard.tsx
    • CodeSegment.tsx
  • Added new components:
    • JavaScriptIcon.tsx
    • TypeScriptIcon.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2024

⚠️ No Changeset found

Latest commit: 7b40f2e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 1:33am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Sep 27, 2024 1:33am
thirdweb_playground ⬜️ Skipped (Inspect) Sep 27, 2024 1:33am
wallet-ui ⬜️ Skipped (Inspect) Sep 27, 2024 1:33am

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 26, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel vercel bot temporarily deployed to Preview – docs-v2 September 26, 2024 12:43 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 26, 2024 12:43 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 26, 2024 12:43 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Sep 26, 2024
@kien-ngo kien-ngo changed the title Replace JS and TS icons [Dashboard] Replace JS and TS icons Sep 26, 2024
@kien-ngo kien-ngo marked this pull request as ready for review September 26, 2024 12:43
@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.93 KB (0%) 839 ms (0%) 1.3 s (+50.99% 🔺) 2.1 s
thirdweb (cjs) 101.55 KB (0%) 2.1 s (0%) 2.5 s (+20.89% 🔺) 4.5 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 131 ms (-18.07% 🔽) 228 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 35 ms (-13.55% 🔽) 45 ms
thirdweb/react (minimal + tree-shaking) 16.78 KB (0%) 336 ms (0%) 223 ms (+31.22% 🔺) 559 ms

@kien-ngo kien-ngo added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Sep 26, 2024 — with Graphite App
@codecov
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.67%. Comparing base (c1d94ae) to head (7b40f2e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4812   +/-   ##
=======================================
  Coverage   47.67%   47.67%           
=======================================
  Files        1051     1051           
  Lines       56715    56715           
  Branches     3894     3894           
=======================================
  Hits        27040    27040           
  Misses      28988    28988           
  Partials      687      687           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from c1d94ae
packages 43.40% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Member

@MananTank MananTank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

address comments

@kien-ngo kien-ngo force-pushed the kien/replace-branding-icons branch from 1c4ba58 to 8505b7d Compare September 26, 2024 15:05
@kien-ngo kien-ngo force-pushed the kien/replace-typescript-and-js-icons branch from 74d2974 to 1e4322b Compare September 26, 2024 15:05
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 26, 2024 15:05 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 26, 2024 15:05 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 26, 2024 15:05 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 27, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on replacing existing icon imports for `JavaScript` and `TypeScript` with custom icon components, enhancing the visual representation in the application.

### Detailed summary
- Replaced `SiJavascript` with `JavaScriptIcon` in `ConnectPlaygroundButton.tsx`, `CodeOptionButton.tsx`, `CodeSegment.tsx`.
- Replaced `SiTypescript` with `TypeScriptIcon` in `SupportedPlatformLink.tsx`, `ConnectSDKCard.tsx`, `CodeSegment.tsx`.
- Added new components: `JavaScriptIcon.tsx` and `TypeScriptIcon.tsx` for custom icons.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the kien/replace-branding-icons branch from a226372 to c1d94ae Compare September 27, 2024 01:24
@MananTank MananTank force-pushed the kien/replace-typescript-and-js-icons branch from 68ed249 to 7b40f2e Compare September 27, 2024 01:24
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 27, 2024 01:24 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 27, 2024 01:24 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 27, 2024 01:24 Inactive
Base automatically changed from kien/replace-branding-icons to main September 27, 2024 01:34
@graphite-app graphite-app bot merged commit 7b40f2e into main Sep 27, 2024
@graphite-app graphite-app bot deleted the kien/replace-typescript-and-js-icons branch September 27, 2024 01:35
@vercel vercel bot temporarily deployed to Production – docs-v2 September 27, 2024 01:35 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground September 27, 2024 01:35 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui September 27, 2024 01:35 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www September 27, 2024 01:52 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. DO NOT MERGE This pull request is still in progress and is not ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants