-
Notifications
You must be signed in to change notification settings - Fork 619
[Dashboard] Replace JS and TS icons #4812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4812 +/- ##
=======================================
Coverage 47.67% 47.67%
=======================================
Files 1051 1051
Lines 56715 56715
Branches 3894 3894
=======================================
Hits 27040 27040
Misses 28988 28988
Partials 687 687
*This pull request uses carry forward flags. Click here to find out more. |
MananTank
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
address comments
1c4ba58 to
8505b7d
Compare
74d2974 to
1e4322b
Compare
4e54b82 to
a226372
Compare
cb8d184 to
68ed249
Compare
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on replacing existing icon imports for `JavaScript` and `TypeScript` with custom icon components, enhancing the visual representation in the application.
### Detailed summary
- Replaced `SiJavascript` with `JavaScriptIcon` in `ConnectPlaygroundButton.tsx`, `CodeOptionButton.tsx`, `CodeSegment.tsx`.
- Replaced `SiTypescript` with `TypeScriptIcon` in `SupportedPlatformLink.tsx`, `ConnectSDKCard.tsx`, `CodeSegment.tsx`.
- Added new components: `JavaScriptIcon.tsx` and `TypeScriptIcon.tsx` for custom icons.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
a226372 to
c1d94ae
Compare
68ed249 to
7b40f2e
Compare

Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on replacing icon imports for
JavaScriptandTypeScriptwith custom components, enhancing the visual representation in various components.Detailed summary
SiJavascriptwithJavaScriptIconin:ConnectPlaygroundButton.tsxCodeOptionButton.tsxCodeSegment.tsxSiTypescriptwithTypeScriptIconin:SupportedPlatformLink.tsxConnectSDKCard.tsxCodeSegment.tsxJavaScriptIcon.tsxTypeScriptIcon.tsx